From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 05 Apr 2013 16:30:00 +0000 Subject: Re: [PATCH 5/8] rcar-phy: correct base address Message-Id: <515EFC08.8000308@cogentembedded.com> List-Id: References: <201304050305.15517.sergei.shtylyov@cogentembedded.com> <20130405004356.GP29203@verge.net.au> In-Reply-To: <20130405004356.GP29203@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 05-04-2013 4:43, Simon Horman wrote: >> The memory region that is used by the driver overlaps EHCI and OHCI register >> regions for absolutely no reason now -- fix it by adding offset of 0x800 to >> the base address, changing the register #define's accordingly. This has extra >> positive effect that we now can use devm_ioremap_resource(). >> Signed-off-by: Sergei Shtylyov > As per my comment regarding patch 4, I wonder if this > could be split into a driver patch and an SoC patch. Absolutely not. That'll break bisection. WBR, Sergei