From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/8] ehci-platform: add init() method to platform data
Date: Fri, 05 Apr 2013 20:40:46 +0000 [thread overview]
Message-ID: <515F36CE.7050804@cogentembedded.com> (raw)
In-Reply-To: <201304050259.51025.sergei.shtylyov@cogentembedded.com>
Hello.
On 04/05/2013 06:43 PM, Alan Stern wrote:
>
>> Sometimes there is a need to initialize some non-standard registers mapped to
>> the EHCI region before accessing the standard EHCI registers. Add the init()
>> method to the 'ehci-platform' platform data for this purpose.
> "init" isn't such a good name for this. It's too vague; there are
> already a lot of initialization steps here. How about "pre_setup"
> instead?
Quite vague too. :-)
But can't think of a better name...
>
>> --- renesas.orig/drivers/usb/host/ehci-platform.c
>> +++ renesas/drivers/usb/host/ehci-platform.c
>> @@ -110,6 +110,13 @@ static int ehci_platform_probe(struct pl
>> err = PTR_ERR(hcd->regs);
>> goto err_put_hcd;
>> }
>> +
>> + if (pdata->init) {
>> + err = pdata->init(dev, hcd->regs);
>> + if (err < 0)
>> + goto err_put_hcd;
>> + }
> Also, I think this code should go in the ehci_platform_reset() routine,
> just before the call to ehci_setup(). That way more of the setup will
> already have been carried out.
You're right, of course.
> And instead of passing hcd->regs, wouldn't it be better to pass hcd?
I really don't know.
> Other users of this interface might need to initialize something other
> than a non-standard register.
Hm, maybe... if passing 'struct usb_hcd *' would indeed help here.
Do you think it's
worth passing 'struct platform_device *' along with it?
> Alan Stern
>
WBR, Sergei
next prev parent reply other threads:[~2013-04-05 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 22:59 [PATCH 2/8] ehci-platform: add init() method to platform data Sergei Shtylyov
2013-04-05 14:43 ` Alan Stern
2013-04-05 20:40 ` Sergei Shtylyov [this message]
2013-04-05 20:48 ` Sergei Shtylyov
2013-04-05 20:55 ` Alan Stern
2013-04-05 20:56 ` Alan Stern
2013-04-05 20:59 ` Sergei Shtylyov
2013-04-05 21:15 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515F36CE.7050804@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox