From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Tue, 16 Apr 2013 14:02:32 +0000 Subject: Re: [PATCH] sh-pfc: R8A7779: add VIN pin groups Message-Id: <516D59F8.6030801@cogentembedded.com> List-Id: References: <201304120251.38652.sergei.shtylyov@cogentembedded.com> In-Reply-To: <201304120251.38652.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello. On 16-04-2013 13:09, Laurent Pinchart wrote: >>>> +/* - VIN0 >>>> ------------------------------------------------------------------- */ >>>> +static const unsigned int vin0_data8_pins[] = { >>>> + /* D[0:7] */ >>>> + 70, 71, 72, 73, 74, 75, 76, 77, >>>> +}; >>> Can you use RCAR_GP_PIN() macro on this patch ? >>> 0bd898b16cdc0a4512d0b1af2fbe1174d217dd2d >>> (gpio-rcar: Add RCAR_GP_PIN macro) >> I think there should be a wholesale conversion patch for all this file. > The whole file has been converted already in tags/renesas-next-20130416. Could > you please rebase this patch on top of that tag and resubmit, with the > hardcoded pin numbers replaced with the RCAR_GP_PIN() macro ? OK, done. Will post it soon... WBR, Sergei