* [PATCH] ARM: shmobile: marzen: keep local function as static
@ 2013-04-18 6:33 Kuninori Morimoto
2013-04-18 13:36 ` Simon Horman
2013-04-18 22:39 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2013-04-18 6:33 UTC (permalink / raw)
To: linux-sh
marzen_init_late() should be static
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/mach-shmobile/board-marzen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-marzen.c b/arch/arm/mach-shmobile/board-marzen.c
index fac9e0f..ff8111b 100644
--- a/arch/arm/mach-shmobile/board-marzen.c
+++ b/arch/arm/mach-shmobile/board-marzen.c
@@ -350,7 +350,7 @@ static struct platform_device *marzen_late_devices[] __initdata = {
&ohci1_device,
};
-void __init marzen_init_late(void)
+static void __init marzen_init_late(void)
{
/* get usb phy */
phy = usb_get_phy(USB_PHY_TYPE_USB2);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: marzen: keep local function as static
2013-04-18 6:33 [PATCH] ARM: shmobile: marzen: keep local function as static Kuninori Morimoto
@ 2013-04-18 13:36 ` Simon Horman
2013-04-18 22:39 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2013-04-18 13:36 UTC (permalink / raw)
To: linux-sh
On Wed, Apr 17, 2013 at 11:33:47PM -0700, Kuninori Morimoto wrote:
> marzen_init_late() should be static
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks, queued-up for v3.11 int the boards-marzen branch.
> ---
> arch/arm/mach-shmobile/board-marzen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/board-marzen.c b/arch/arm/mach-shmobile/board-marzen.c
> index fac9e0f..ff8111b 100644
> --- a/arch/arm/mach-shmobile/board-marzen.c
> +++ b/arch/arm/mach-shmobile/board-marzen.c
> @@ -350,7 +350,7 @@ static struct platform_device *marzen_late_devices[] __initdata = {
> &ohci1_device,
> };
>
> -void __init marzen_init_late(void)
> +static void __init marzen_init_late(void)
> {
> /* get usb phy */
> phy = usb_get_phy(USB_PHY_TYPE_USB2);
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: marzen: keep local function as static
2013-04-18 6:33 [PATCH] ARM: shmobile: marzen: keep local function as static Kuninori Morimoto
2013-04-18 13:36 ` Simon Horman
@ 2013-04-18 22:39 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-04-18 22:39 UTC (permalink / raw)
To: linux-sh
Hello.
On 04/18/2013 10:33 AM, Kuninori Morimoto wrote:
> marzen_init_late() should be static
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/board-marzen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/board-marzen.c b/arch/arm/mach-shmobile/board-marzen.c
> index fac9e0f..ff8111b 100644
> --- a/arch/arm/mach-shmobile/board-marzen.c
> +++ b/arch/arm/mach-shmobile/board-marzen.c
> @@ -350,7 +350,7 @@ static struct platform_device *marzen_late_devices[] __initdata = {
> &ohci1_device,
> };
>
> -void __init marzen_init_late(void)
> +static void __init marzen_init_late(void)
Grr, I'm killing this function with my R8A7779 USB patchset!
You've only caused me to respin it extra time... although R8A7778
patchset needed a respin too. :-(
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-18 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-18 6:33 [PATCH] ARM: shmobile: marzen: keep local function as static Kuninori Morimoto
2013-04-18 13:36 ` Simon Horman
2013-04-18 22:39 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).