From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code
Date: Fri, 19 Apr 2013 11:44:46 +0000 [thread overview]
Message-ID: <51712E2E.8040105@cogentembedded.com> (raw)
In-Reply-To: <20130419021755.GF25718@verge.net.au>
Hello.
On 19-04-2013 6:17, Simon Horman wrote:
>>>> +/* USB PHY */
>>>> +static struct resource usb_phy_resources[] = {
>>>> + [0] = {
>>>> + .start = 0xffe70000,
>>>> + .end = 0xffe70900 - 1,
>>>> + .flags = IORESOURCE_MEM,
>>>> + },
>>>> + [1] = {
>>>> + .start = 0xfff70000,
>>>> + .end = 0xfff70900 - 1,
>>>> + .flags = IORESOURCE_MEM,
>>>> + },
>>> Please consider using the macros for these initialisers.
>> I'm just moving the code as is here. The destination file still
>> uses old style initializers, and probably needs the wholesale
>> conversion patch in the future.
> My preference is for you to either convert these users in this patch or
> provide a patch that makes a wholesale conversion.
I'll try to do the latter but my load is currently very high, so that
may take some time.
WBR, Sergei
next prev parent reply other threads:[~2013-04-19 11:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 22:57 [PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code Sergei Shtylyov
2013-04-05 0:41 ` Simon Horman
2013-04-05 15:47 ` Sergei Shtylyov
2013-04-05 18:46 ` Sergei Shtylyov
2013-04-18 15:44 ` Russell King - ARM Linux
2013-04-18 17:40 ` Sergei Shtylyov
2013-04-19 2:17 ` Simon Horman
2013-04-19 11:44 ` Sergei Shtylyov [this message]
2013-04-22 3:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51712E2E.8040105@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).