From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/6] ARM: shmobile: r8a7778: Register SDHI device
Date: Fri, 19 Apr 2013 18:27:08 +0000 [thread overview]
Message-ID: <51718C7C.2040705@cogentembedded.com> (raw)
In-Reply-To: <87bo9denxa.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 04/17/2013 09:17 AM, Kuninori Morimoto wrote:
> This patch adds SDHI register function which needs id number (= 0/1/2)
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/include/mach/r8a7778.h | 2 ++
> arch/arm/mach-shmobile/setup-r8a7778.c | 24 ++++++++++++++++++++++++
> 2 files changed, 26 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/include/mach/r8a7778.h b/arch/arm/mach-shmobile/include/mach/r8a7778.h
> index 68053fc..ae65b45 100644
> --- a/arch/arm/mach-shmobile/include/mach/r8a7778.h
> +++ b/arch/arm/mach-shmobile/include/mach/r8a7778.h
> @@ -18,6 +18,7 @@
> #ifndef __ASM_R8A7778_H__
> #define __ASM_R8A7778_H__
>
> +#include <linux/mmc/sh_mobile_sdhi.h>
> #include <linux/sh_eth.h>
>
> extern void r8a7778_add_standard_devices(void);
> @@ -29,5 +30,6 @@ extern void r8a7778_init_irq_dt(void);
> extern void r8a7778_clock_init(void);
> extern void r8a7778_init_irq_extpin(int irlm);
> extern void r8a7778_pinmux_init(void);
> +extern void r8a7778_sdhi_init(int id, struct sh_mobile_sdhi_info *info);
You should have called the function r8a7778_add_sdhi_device() to be in
the same vein with already added registration functions. I'll prepare a
renaming patch if you don't beat me to it.
WBR, Sergei
next prev parent reply other threads:[~2013-04-19 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 5:17 [PATCH 3/6] ARM: shmobile: r8a7778: Register SDHI device Kuninori Morimoto
2013-04-18 12:07 ` Simon Horman
2013-04-19 18:27 ` Sergei Shtylyov [this message]
2013-04-22 0:48 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51718C7C.2040705@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox