From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2 v7] sudmac: add support for SUDMAC
Date: Tue, 23 Apr 2013 04:18:23 +0000 [thread overview]
Message-ID: <51760B8F.4020509@renesas.com> (raw)
In-Reply-To: <5174FDF3.8060809@renesas.com>
Hi Morimoto-san,
Thank you for the comment.
(2013/04/23 9:41), Kuninori Morimoto wrote:
< snip >
>> diff --git a/drivers/dma/sh/Makefile b/drivers/dma/sh/Makefile
>> index 54ae957..16f9225 100644
>> --- a/drivers/dma/sh/Makefile
>> +++ b/drivers/dma/sh/Makefile
>> @@ -1,2 +1,3 @@
>> obj-$(CONFIG_SH_DMAE) += shdma-base.o
>> obj-$(CONFIG_SH_DMAE) += shdma.o
>> +obj-$(CONFIG_SUDMAC) += shdma-base.o sudmac.o
>
> I'm not sure detail of it, but, I thought we can do like this.
> Is it possible ?
It is possible, I think.
But,
> --- Kconfig ---
> config SH_DMAE_BASE
> xxx
>
> config SH_DMAE
> xxx
> depends on SH_DMAE_BASE
>
> config SH_SUDMAC
> xxx
> depends on SH_DMAE_BASE
it can choose the SH_DMAE_BASE only, but we will use
"SH_DMAE_BASE && SH_DMAE" or "SH_DMAE_BASE && SH_SUDMAC".
So, I intend to modify the Kconfig like the "config DMA_ENGINE":
--- Kconfig ---
config SH_DMAE
xxx
select SH_DMAE_BASE
config SUDMAC
xxx
select SH_DMAE_BASE
---------------
What do you think about this?
> --- Makefile ---
>
> obj-$(CONFIG_SH_DMAE_BASE) += shdma-base.o
> obj-$(CONFIG_SH_DMAE) += shdma.o
> obj-$(CONFIG_SUDMAC) += sudmac.o
I think it is nice.
Best regards,
Yoshihiro Shimoda
> Best regards
> ---
> Kuninori Morimoto
>
next prev parent reply other threads:[~2013-04-23 4:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 9:08 [PATCH 2/2 v7] sudmac: add support for SUDMAC Shimoda, Yoshihiro
2013-04-23 0:41 ` Kuninori Morimoto
2013-04-23 4:18 ` Shimoda, Yoshihiro [this message]
2013-04-23 5:08 ` Kuninori Morimoto
2013-04-23 6:43 ` Vinod Koul
2013-04-23 10:50 ` Shimoda, Yoshihiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51760B8F.4020509@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).