From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups
Date: Sun, 05 May 2013 11:36:42 +0000 [thread overview]
Message-ID: <5186444A.8010807@cogentembedded.com> (raw)
In-Reply-To: <201304270246.43931.sergei.shtylyov@cogentembedded.com>
Hello.
On 03-05-2013 11:40, Linus Walleij wrote:
>>>> I really don't think the macros make the code more readable here,
>>>> especially with the explicit array/macros mix, but I won't nack the patch
>>>> just for that.
>>> But you won't ACK it either? :-)
>> I definitely wouldn't have written the code that way, but the patch looks OK
>> to me and can be applied. According to Documentation/SubmittingPatches that's
>> equivalent to
>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> If Laurent is OK with it, I'm OK with it.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
How about patch #3 of this series?
> Yours,
> Linus Walleij
WBR, Sergei
prev parent reply other threads:[~2013-05-05 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 22:46 [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups Sergei Shtylyov
2013-04-27 0:48 ` Laurent Pinchart
2013-04-27 14:41 ` Sergei Shtylyov
2013-04-28 20:55 ` Laurent Pinchart
2013-05-03 7:40 ` Linus Walleij
2013-05-05 11:36 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5186444A.8010807@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).