From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sun, 05 May 2013 11:36:42 +0000 Subject: Re: [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups Message-Id: <5186444A.8010807@cogentembedded.com> List-Id: References: <201304270246.43931.sergei.shtylyov@cogentembedded.com> In-Reply-To: <201304270246.43931.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello. On 03-05-2013 11:40, Linus Walleij wrote: >>>> I really don't think the macros make the code more readable here, >>>> especially with the explicit array/macros mix, but I won't nack the patch >>>> just for that. >>> But you won't ACK it either? :-) >> I definitely wouldn't have written the code that way, but the patch looks OK >> to me and can be applied. According to Documentation/SubmittingPatches that's >> equivalent to >> Acked-by: Laurent Pinchart > If Laurent is OK with it, I'm OK with it. > Acked-by: Linus Walleij How about patch #3 of this series? > Yours, > Linus Walleij WBR, Sergei