[PATCH v2 3/3] sh-pfc: r8a7779: add Ether pin groups

[PATCH v2 3/3] sh-pfc: r8a7779: add Ether pin groups

[Sergei Shtylyov]

Add Ether RMII/LINK/MAGIC pin groups to R8A7779 PFC driver.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
Changes from the original posting:
- moved all pin groups to stay in the alphabetical order with the others.

 drivers/pinctrl/sh-pfc/pfc-r8a7779.c |   42 +++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
=================================--- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
+++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
@@ -1640,6 +1640,38 @@ static const unsigned int du1_cde_pins[]
 static const unsigned int du1_cde_mux[] = {
 	DU1_CDE_MARK
 };
+/* - Ether ------------------------------------------------------------------ */
+static const unsigned int ether_rmii_pins[] = {
+	/*
+	 * ETH_TXD0, ETH_TXD1, ETH_TX_EN,  ETH_REFCLK,
+	 * ETH_RXD0, ETH_RXD1, ETH_CRS_DV, ETH_RX_ER,
+	 * ETH_MDIO, ETH_MDC
+	 */
+	RCAR_GP_PIN(2, 27), RCAR_GP_PIN(2, 16), RCAR_GP_PIN(2, 18),
+	RCAR_GP_PIN(2, 26),
+	RCAR_GP_PIN(2, 20), RCAR_GP_PIN(2, 21), RCAR_GP_PIN(2, 17),
+	RCAR_GP_PIN(2, 19),
+	RCAR_GP_PIN(2, 29), RCAR_GP_PIN(2, 28),
+};
+static const unsigned int ether_rmii_mux[] = {
+	ETH_TXD0_MARK, ETH_TXD1_MARK, ETH_TX_EN_MARK,  ETH_REFCLK_MARK,
+	ETH_RXD0_MARK, ETH_RXD1_MARK, ETH_CRS_DV_MARK, ETH_RX_ER_MARK,
+	ETH_MDIO_MARK, ETH_MDC_MARK,
+};
+static const unsigned int ether_link_pins[] = {
+	/* ETH_LINK */
+	RCAR_GP_PIN(2, 24),
+};
+static const unsigned int ether_link_mux[] = {
+	ETH_LINK_MARK,
+};
+static const unsigned int ether_magic_pins[] = {
+	/* ETH_MAGIC */
+	RCAR_GP_PIN(2, 25),
+};
+static const unsigned int ether_magic_mux[] = {
+	ETH_MAGIC_MARK,
+};
 /* - HSPI0 ------------------------------------------------------------------ */
 static const unsigned int hspi0_pins[] = {
 	/* CLK, CS, RX, TX */
@@ -2537,6 +2569,9 @@ static const struct sh_pfc_pin_group pin
 	SH_PFC_PIN_GROUP(du1_sync_1),
 	SH_PFC_PIN_GROUP(du1_oddf),
 	SH_PFC_PIN_GROUP(du1_cde),
+	SH_PFC_PIN_GROUP(ether_rmii),
+	SH_PFC_PIN_GROUP(ether_link),
+	SH_PFC_PIN_GROUP(ether_magic),
 	SH_PFC_PIN_GROUP(hspi0),
 	SH_PFC_PIN_GROUP(hspi1),
 	SH_PFC_PIN_GROUP(hspi1_b),
@@ -2679,6 +2714,12 @@ static const char * const du1_groups[]  	"du1_cde",
 };
 
+static const char * const ether_groups[] = {
+	"ether_rmii",
+	"ether_link",
+	"ether_magic",
+};
+
 static const char * const hspi0_groups[] = {
 	"hspi0",
 };
@@ -2871,6 +2912,7 @@ static const char * const vin3_groups[] 
 static const struct sh_pfc_function pinmux_functions[] = {
 	SH_PFC_FUNCTION(du0),
 	SH_PFC_FUNCTION(du1),
+	SH_PFC_FUNCTION(ether),
 	SH_PFC_FUNCTION(hspi0),
 	SH_PFC_FUNCTION(hspi1),
 	SH_PFC_FUNCTION(hspi2),

Re: [PATCH v2 3/3] sh-pfc: r8a7779: add Ether pin groups

[Linus Walleij]

On Fri, Apr 26, 2013 at 11:10 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:

> Add Ether RMII/LINK/MAGIC pin groups to R8A7779 PFC driver.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH v2 3/3] sh-pfc: r8a7779: add Ether pin groups

[Sergei Shtylyov]

Hello.

On 06-05-2013 0:03, Linus Walleij wrote:

>> Add Ether RMII/LINK/MAGIC pin groups to R8A7779 PFC driver.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Acked-by: Linus Walleij <linus.walleij@linaro.org>

    Thanks, Linus.
    Simon, will you now queue this series for 3.11 when all ACKs have 
been gathered?

> Yours,
> Linus Walleij

WBR, Sergei

Re: [PATCH v2 3/3] sh-pfc: r8a7779: add Ether pin groups

[Simon Horman]

On Tue, May 07, 2013 at 06:27:02PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 06-05-2013 0:03, Linus Walleij wrote:
> 
> >>Add Ether RMII/LINK/MAGIC pin groups to R8A7779 PFC driver.
> 
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
>    Thanks, Linus.
>    Simon, will you now queue this series for 3.11 when all ACKs have
> been gathered?

Yes, sure.

Re: [PATCH v2 3/3] sh-pfc: r8a7779: add Ether pin groups

[Sergei Shtylyov]

Hello.

On 09-05-2013 10:57, Simon Horman wrote:

>>>> Add Ether RMII/LINK/MAGIC pin groups to R8A7779 PFC driver.

>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>>> Acked-by: Linus Walleij <linus.walleij@linaro.org>

>>     Thanks, Linus.
>>     Simon, will you now queue this series for 3.11 when all ACKs have
>> been gathered?

> Yes, sure.

    I have just respun it with one patch added, so the ACK gathering 
cycle will have to continue. :-)

WBR, Sergei