From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 10 May 2013 10:35:01 +0000 Subject: Re: [PATCH 2/2] ARM: shmobile: lager: enable Ether Message-Id: <518CCD55.6070101@cogentembedded.com> List-Id: References: <1368173119-27345-1-git-send-email-horms+renesas@verge.net.au> <1368173119-27345-3-git-send-email-horms+renesas@verge.net.au> In-Reply-To: <1368173119-27345-3-git-send-email-horms+renesas@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 10-05-2013 12:05, Simon Horman wrote: > Cc: Sergei Shtylyov > Signed-off-by: Simon Horman > --- > This patch has a run-time dependency on "sh_eth: add support for r8a7790 SoC". > --- > arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > arch/arm/mach-shmobile/board-lager.c | 26 ++++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 1 deletion(-) > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > index 09a84fc..b2f61f0 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > @@ -16,7 +16,7 @@ > compatible = "renesas,lager", "renesas,r8a7790"; > > chosen { > - bootargs = "console=ttySC6,115200 ignore_loglevel"; > + bootargs = "console=ttySC6,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize@96,wsize@96 rw"; > }; > > memory@40000000 { Perhaps you shouldn't mix .dts changes with source changes? > diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c > index 6a1ba38..0b8112d 100644 > --- a/arch/arm/mach-shmobile/board-lager.c > +++ b/arch/arm/mach-shmobile/board-lager.c [...] > @@ -59,6 +69,17 @@ static const struct pinctrl_map lager_pinctrl_map[] = { > /* SCIF1 (CN20: DEBUG SERIAL1) */ > PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790", > "scif1_data", "scif1"), > + /* Ether */ > + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790", > + "eth_link", "eth"), > + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790", > + "eth_magic", "eth"), > + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790", > + "eth_mdio", "eth"), > + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790", > + "eth_rmii", "eth"), I thought MDIO bus was a part of RMII. At least Wikipedia told me so. :-) WBR, Sergei