From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 13 May 2013 13:04:41 +0000 Subject: Re: [PATCH 2/2] ARM: shmobile: lager: enable Ether Message-Id: <5190E4E9.20100@cogentembedded.com> List-Id: References: <1368173119-27345-1-git-send-email-horms+renesas@verge.net.au> <1368173119-27345-3-git-send-email-horms+renesas@verge.net.au> <518CCD55.6070101@cogentembedded.com> <20130513004001.GC22911@verge.net.au> In-Reply-To: <20130513004001.GC22911@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 13.05.2013 4:40, Simon Horman wrote: > [ CC Laurent ] >>> Cc: Sergei Shtylyov >>> Signed-off-by: Simon Horman >>> --- >>> This patch has a run-time dependency on "sh_eth: add support for r8a7790 SoC". [...] >>> diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c >>> index 6a1ba38..0b8112d 100644 >>> --- a/arch/arm/mach-shmobile/board-lager.c >>> +++ b/arch/arm/mach-shmobile/board-lager.c >> [...] >>> @@ -59,6 +69,17 @@ static const struct pinctrl_map lager_pinctrl_map[] = { >>> /* SCIF1 (CN20: DEBUG SERIAL1) */ >>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790", >>> "scif1_data", "scif1"), >>> + /* Ether */ >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790", >>> + "eth_link", "eth"), >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790", >>> + "eth_magic", "eth"), >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790", >>> + "eth_mdio", "eth"), >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790", >>> + "eth_rmii", "eth"), >> I thought MDIO bus was a part of RMII. At least Wikipedia told >> me so. :-) > Is the implication that you think that the eth_mdio and eth_rmii > groups should be combined? Well, yes. WBR, Sergei