From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: shmobile: r8a7790: add Ether support
Date: Mon, 13 May 2013 13:07:49 +0000 [thread overview]
Message-ID: <5190E5A5.8030605@cogentembedded.com> (raw)
In-Reply-To: <20130513004314.GD22911@verge.net.au>
Hello.
On 13-05-2013 4:43, Simon Horman wrote:
>>> Add Ether clock and platform device for R8A7779 SoC; add a function to
>>> register this device with board-specific platform data.
>>> Based on a similar change for the r8a7779 by Sergei Shtylyov.
>>> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[...]
>>> diff --git a/arch/arm/mach-shmobile/include/mach/r8a7790.h b/arch/arm/mach-shmobile/include/mach/r8a7790.h
>>> index 2e919e6..95b8f7e 100644
>>> --- a/arch/arm/mach-shmobile/include/mach/r8a7790.h
>>> +++ b/arch/arm/mach-shmobile/include/mach/r8a7790.h
>>> @@ -1,9 +1,12 @@
>>> #ifndef __ASM_R8A7790_H__
>>> #define __ASM_R8A7790_H__
>>>
>>> +#include <linux/sh_eth.h>
>>> +
>>> void r8a7790_add_standard_devices(void);
>>> void r8a7790_clock_init(void);
>>> void r8a7790_pinmux_init(void);
>>> void r8a7790_timer_init(void);
>>> +void r8a7790_add_ether_device(struct sh_eth_plat_data *pdata);
>> Perhaps better place is right after r8a7790_add_standard_devices()...
> Is the implication that the struct sh_eth_plat_data can be defined
> in setup-r8a7790.c?
No, why?
> Or do you for see adding a struct sh_eth_plat_data
> parameter to r8a7790_add_standard_devices() ?
Not at all.
WBR, Sergei
next prev parent reply other threads:[~2013-05-13 13:07 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 8:05 [PATCH 0/2] ARM: shmobile: lager: enable Ether Simon Horman
2013-05-10 8:05 ` [PATCH 1/2] ARM: shmobile: r8a7790: add Ether support Simon Horman
2013-05-10 10:26 ` Sergei Shtylyov
2013-05-13 0:43 ` Simon Horman
2013-05-13 13:07 ` Sergei Shtylyov [this message]
2013-05-14 0:29 ` Simon Horman
2013-10-15 9:08 ` [PATCH 1/2] ARM: shmobile: r8a7790: add QSPI support Cao Minh Hiep
2013-10-16 0:39 ` Simon Horman
2013-10-16 0:46 ` Magnus Damm
2013-10-16 1:49 ` Simon Horman
2013-10-16 11:03 ` カオ ミン ヒェップ
2013-10-17 0:13 ` Kuninori Morimoto
2013-10-17 0:52 ` Simon Horman
2013-10-17 1:40 ` Simon Horman
2013-10-17 3:27 ` カオ ミン ヒェップ
2013-10-17 4:32 ` Kuninori Morimoto
2013-10-17 8:04 ` カオ ミン ヒェップ
2013-10-18 0:44 ` Kuninori Morimoto
2013-10-18 1:06 ` カオ ミン ヒェップ
2013-12-13 11:52 ` [PATCH 1/2] arm: shmobile: r8a7790: Add PCI USB host clock support Valentine Barshak
2013-12-19 17:57 ` [PATCH 1/2] arm: shmobile: r8a7790: Add SATA clock Valentine Barshak
2013-12-24 18:55 ` [PATCH 1/2] arm: shmobile: r8a7790: Add VIN clock support Valentine Barshak
2013-12-26 15:35 ` Valentine Barshak
2014-01-06 8:32 ` [PATCH 1/2] ARM: shmobile: r8a7790: add Audio DMAC clock Kuninori Morimoto
2014-01-08 4:17 ` Simon Horman
2014-01-08 4:23 ` Simon Horman
2014-01-08 6:08 ` Kuninori Morimoto
2014-01-09 8:07 ` Simon Horman
2014-04-08 16:35 ` [PATCH 1/2] ARM: shmobile: r8a7790: Add VSP1 devices to DT Laurent Pinchart
2014-05-29 10:59 ` [PATCH 1/2] arm: shmobile: r8a7790: add USB3.0 clocks to device tree Yoshihiro Shimoda
2014-06-26 0:52 ` [PATCH 1/2] ARM: shmobile: r8a7790: add DVC support for sound node on DTSI Kuninori Morimoto
2014-09-13 23:36 ` [PATCH 1/2] ARM: shmobile: r8a7790: Add VSP1 devices to DT Laurent Pinchart
2014-09-14 17:58 ` Sergei Shtylyov
2014-09-14 23:32 ` Laurent Pinchart
2014-09-30 4:23 ` Simon Horman
2014-09-30 8:51 ` Laurent Pinchart
2014-09-30 23:55 ` Simon Horman
2015-01-08 1:55 ` [PATCH 1/2] ARM: shmobile: r8a7790: add SRC interrupt number on DTSI Kuninori Morimoto
2013-05-10 8:05 ` [PATCH 2/2] ARM: shmobile: lager: enable Ether Simon Horman
2013-05-10 10:35 ` Sergei Shtylyov
2013-05-13 0:40 ` Simon Horman
2013-05-13 13:04 ` Sergei Shtylyov
2013-05-13 22:30 ` Laurent Pinchart
2013-05-13 22:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5190E5A5.8030605@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).