Re: [PATCH 8/9] ARM: shmobile: APE6EVM: switch to using platform_add_devices()

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 05/17/2013 06:55 PM, Guennadi Liakhovetski wrote:

> Switch from platform_device_register_resndata() to platform_add_devices()
> to make adding new devices easier.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>   arch/arm/mach-shmobile/board-ape6evm.c |   26 +++++++++++++++++++++-----
>   1 files changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> index 5eb0caa..9c69643 100644
> --- a/arch/arm/mach-shmobile/board-ape6evm.c
> +++ b/arch/arm/mach-shmobile/board-ape6evm.c
[...]
> @@ -64,6 +74,13 @@ static const struct pinctrl_map ape6evm_pinctrl_map[] = {
>   				  "irqc_irq40", "irqc"),
>   };
>   
> +/*
> + * board devices
> + */
> +static struct platform_device *ape6evm_devices[] __initdata = {
> +	&lan9220_device,
> +};
> +
>   static void __init ape6evm_add_standard_devices(void)
>   {
>   
> @@ -91,9 +108,8 @@ static void __init ape6evm_add_standard_devices(void)
>   
>   	regulator_register_fixed(0, dummy_supplies, ARRAY_SIZE(dummy_supplies));
>   
> -	platform_device_register_resndata(&platform_bus, "smsc911x", -1,
> -					  lan9220_res, ARRAY_SIZE(lan9220_res),
> -					  &lan9220_data, sizeof(lan9220_data));
> +	platform_add_devices(ape6evm_devices,
> +			     ARRAY_SIZE(ape6evm_devices));

    We have been discouraged from using platform_device_register() and 
its ilk by Greg KH and Arnd, so

platform_device_register_resndata() might have been there on purpose.


WBR, Sergei