From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 08/17 v2] ARM: shmobile: r8a7778: add MMCIF support
Date: Thu, 23 May 2013 12:53:34 +0000 [thread overview]
Message-ID: <519E114E.6070905@cogentembedded.com> (raw)
In-Reply-To: <871u8y4c3a.wl%kuninori.morimoto.gx@renesas.com>
On 23-05-2013 7:19, Kuninori Morimoto wrote:
I would like a proper changelog here.
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[...]
> diff --git a/arch/arm/mach-shmobile/clock-r8a7778.c b/arch/arm/mach-shmobile/clock-r8a7778.c
> index c2c1895..842aed7 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7778.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7778.c
[...]
> @@ -137,6 +139,7 @@ static struct clk_lookup lookups[] = {
> CLKDEV_CON_ID("peripheral_clk", &p_clk),
>
> /* MSTP32 clocks */
> + CLKDEV_DEV_ID("sh_mmcif", &mstp_clks[MSTP331]), /* MMC */
Either actually align with others, or use single space after comma.
> CLKDEV_DEV_ID("sh_mobile_sdhi.0", &mstp_clks[MSTP323]), /* SDHI0 */
> CLKDEV_DEV_ID("sh_mobile_sdhi.1", &mstp_clks[MSTP322]), /* SDHI1 */
> CLKDEV_DEV_ID("sh_mobile_sdhi.2", &mstp_clks[MSTP321]), /* SDHI2 */
[...]
> diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c b/arch/arm/mach-shmobile/setup-r8a7778.c
> index 8f011cb..b0cc4ba 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7778.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> @@ -220,6 +220,19 @@ void __init r8a7778_add_hspi_device(int id)
> hspi_resources + (2 * id), 2);
> }
>
> +/* MMC */
> +static struct resource mmc_resources[] = {
You forgot to specify __initdata.
> + DEFINE_RES_MEM(0xffe4e000, 0x100),
> + DEFINE_RES_IRQ(gic_iid(0x5d)),
> +};
WBR, Sergei
prev parent reply other threads:[~2013-05-23 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 3:19 [PATCH 08/17 v2] ARM: shmobile: r8a7778: add MMCIF support Kuninori Morimoto
2013-05-23 12:53 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E114E.6070905@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).