From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 07/17 v2] ARM: shmobile: r8a7778: add HSPI support
Date: Thu, 23 May 2013 12:54:44 +0000 [thread overview]
Message-ID: <519E1194.6040404@cogentembedded.com> (raw)
In-Reply-To: <8738te4c3u.wl%kuninori.morimoto.gx@renesas.com>
On 23-05-2013 7:19, Kuninori Morimoto wrote:
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[...]
> diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c b/arch/arm/mach-shmobile/setup-r8a7778.c
> index 87b74a5..8f011cb 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7778.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> @@ -198,6 +198,29 @@ void __init r8a7778_add_i2c_device(int id)
> i2c_resources + (2 * id), 2);
> }
>
> +/* HSPI */
> +static struct resource hspi_resources[] = {
You forgot to specify __initdata here -- you're just wasting memory.
> + /* HSPI0 */
> + DEFINE_RES_MEM(0xfffc7000, 0x18),
> + DEFINE_RES_IRQ(gic_iid(0x5f)),
> + /* HSPI1 */
> + DEFINE_RES_MEM(0xfffc8000, 0x18),
> + DEFINE_RES_IRQ(gic_iid(0x74)),
> + /* HSPI2 */
> + DEFINE_RES_MEM(0xfffc6000, 0x18),
> + DEFINE_RES_IRQ(gic_iid(0x75)),
> +};
WBR, Sergei
prev parent reply other threads:[~2013-05-23 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 3:19 [PATCH 07/17 v2] ARM: shmobile: r8a7778: add HSPI support Kuninori Morimoto
2013-05-23 12:50 ` Sergei Shtylyov
2013-05-23 12:54 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E1194.6040404@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).