linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 17/17 v2] ARM: shmobile: r8a7778: rename sdhi device additional function
Date: Thu, 23 May 2013 13:09:59 +0000	[thread overview]
Message-ID: <519E1527.1060100@cogentembedded.com> (raw)
In-Reply-To: <87obc22xbi.wl%kuninori.morimoto.gx@renesas.com>

On 23-05-2013 7:24, Kuninori Morimoto wrote:

> Other device additional function are r8a7778_add_xxx_device()
> sdhi also follow it.

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    Thanks for the patch. I didn't find time to do it.

> diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c b/arch/arm/mach-shmobile/setup-r8a7778.c
> index 3e128c3..749d886 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7778.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> @@ -162,7 +162,7 @@ static struct resource sdhi_resources[] __initdata = {
>   	DEFINE_RES_IRQ(gic_iid(0x76)),
>   };
>
> -void __init r8a7778_sdhi_init(int id,
> +void __init r8a7778_add_sdhi_device(int id,
>   			      struct sh_mobile_sdhi_info *info)

    You should have realigned the second line below *int* on the first.

WBR, Sergei


      reply	other threads:[~2013-05-23 13:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-23  3:24 [PATCH 17/17 v2] ARM: shmobile: r8a7778: rename sdhi device additional function Kuninori Morimoto
2013-05-23 13:09 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519E1527.1060100@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).