From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: sh7372 pinmux platform device cleanup
Date: Mon, 27 May 2013 14:04:37 +0000 [thread overview]
Message-ID: <51A367F5.5040500@cogentembedded.com> (raw)
In-Reply-To: <1369648782-8024-2-git-send-email-horms+renesas@verge.net.au>
Hello.
On 27-05-2013 13:59, Simon Horman wrote:
> From: Magnus Damm <damm@opensource.se>
> Use DEFINE_RES_MEM() and platform_device_register_simple()
> to save a couple of lines of code.
> Signed-off-by: Magnus Damm <damm@opensource.se>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm/mach-shmobile/setup-sh7372.c | 24 +++++-------------------
> 1 file changed, 5 insertions(+), 19 deletions(-)
> diff --git a/arch/arm/mach-shmobile/setup-sh7372.c b/arch/arm/mach-shmobile/setup-sh7372.c
> index 5502d62..c70a3cc 100644
> --- a/arch/arm/mach-shmobile/setup-sh7372.c
> +++ b/arch/arm/mach-shmobile/setup-sh7372.c
> @@ -62,29 +62,15 @@ void __init sh7372_map_io(void)
[...]
> +static const struct resource pfc_resources[] = {
This should have been annotated with __initdata... too late now,
need another patch.
> + DEFINE_RES_MEM(0xe6050000, 0x8000),
> + DEFINE_RES_MEM(0xe605800c, 0x001c),
> };
>
> void __init sh7372_pinmux_init(void)
> {
> - platform_device_register(&sh7372_pfc_device);
> + platform_device_register_simple("pfc-sh7372", -1, pfc_resources,
> + ARRAY_SIZE(pfc_resources));
> }
WBR, Sergei
prev parent reply other threads:[~2013-05-27 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 9:59 [GIT PULL v2] Renesas ARM based sh7372 SoC updates for v3.11 Simon Horman
2013-05-27 9:59 ` [PATCH] ARM: shmobile: sh7372 pinmux platform device cleanup Simon Horman
2013-05-27 14:04 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A367F5.5040500@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).