From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: magnus.damm@gmail.com
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh_eth: define/use EESR_RX_CHECK macro
Date: Wed, 19 Jun 2013 18:27:50 +0000 [thread overview]
Message-ID: <51C1F826.6040805@cogentembedded.com> (raw)
In-Reply-To: <20130619.005005.2262835197239818334.davem@davemloft.net>
Hello.
On 06/19/2013 11:50 AM, David Miller wrote:
>> On Wed, Jun 19, 2013 at 7:07 AM, Sergei Shtylyov
>> <sergei.shtylyov@cogentembedded.com> wrote:
>>> sh_eth_interrupt() uses the same Rx interrupt mask twice to check the interrupt
>>> status register -- #define EESR_RX_CHECK and use it instead.
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Thanks for the patch, nice to see that this driver is moving forward.
Magnus, BTW, are you content with the amount of cleanup that is
currently queued in the Dave Miller's 'net-next.git' repo, or should I
move further: e.g., move the SoC specific fields like 'register_type'
from the platform data to the driver's internal data structure?
>> Can you please include information about which SoC / board this code
>> has been tested on? As you know, the actual hardware that this driver
>> is operating on is not very well documented, so at least having
>> information about the SoC together with the commit message or patch
>> may help in the future.
> Sergei, please make this suggested change and resubmit this series, thank you.
Hm, I guess Magnus didn't really mean patch #1 which doesn't change
anything in the driver's behavior but only the actual NAPI support. OK,
it was tested on R8A7778 BOCK-W board and I'll add that to the changelog.
WBR, Sergei
next prev parent reply other threads:[~2013-06-19 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 22:07 [PATCH 1/2] sh_eth: define/use EESR_RX_CHECK macro Sergei Shtylyov
2013-06-19 6:47 ` Magnus Damm
2013-06-19 7:50 ` David Miller
2013-06-19 18:27 ` Sergei Shtylyov [this message]
2013-07-01 12:12 ` Magnus Damm
2013-07-01 12:58 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C1F826.6040805@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox