Re: [PATCH] ARM: shmobile: r8a7740: Fix ethernet device name in clock definition

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 17-07-2013 14:47, Laurent Pinchart wrote:

>>>> The ethernet device is named r8a7740-gether, fix the clock definition
>>>> accordingly.

>>>> Signed-off-by: Laurent Pinchart
>>>> <laurent.pinchart+renesas@ideasonboard.com>
>>>> ---

>>>>    arch/arm/mach-shmobile/clock-r8a7740.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)

>>>> diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c
>>>> b/arch/arm/mach-shmobile/clock-r8a7740.c
>>>> index de10fd7..e1e8710 100644
>>>> --- a/arch/arm/mach-shmobile/clock-r8a7740.c
>>>> +++ b/arch/arm/mach-shmobile/clock-r8a7740.c
>>>> @@ -595,7 +595,7 @@ static struct clk_lookup lookups[] = {
>>>>
>>>>        CLKDEV_DEV_ID("sh_mmcif",        &mstp_clks[MSTP312]),
>>>>        CLKDEV_DEV_ID("e6bd0000.mmcif",         &mstp_clks[MSTP312]),
>>>>        CLKDEV_DEV_ID("r8a7740-gether",        &mstp_clks[MSTP309]),
>>>>
>>>> -    CLKDEV_DEV_ID("e9a00000.sh-eth",    &mstp_clks[MSTP309]),
>>>> +    CLKDEV_DEV_ID("e9a00000.r8a7740-gether", &mstp_clks[MSTP309]),

>>>      Al Ethernet devices should be named "ethernet", according to ePAPR
>>>      spec.

>>      BTW, I'm not seeing a patch to r8a7740.dtsi, describing this device.

> Let's delay this patch until the device gets added to r8a7740.dtsi then.

    I don't see a use for this line even then. sh-eth.c can't be converted to 
device tree due to procedural platform data, so I'm planning to use 
OF_DEV_AUXDATA() for it which doesn't require defining an extra clock.

WBR, Sergei