From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 6/6 v2] ARM: shmobile: r8a7779: cleanup registration of usb phy
Date: Fri, 26 Jul 2013 13:14:48 +0000 [thread overview]
Message-ID: <51F27648.5060405@cogentembedded.com> (raw)
In-Reply-To: <87y58tbwoy.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 26-07-2013 11:35, Kuninori Morimoto wrote:
The subject hardly matches what's being done in the patch.
> usb phy driver which needs platform data at the time of
> registration is used from BockW only.
s/BockW/Marzen/.
> Now, ARM/shmobile aims to support DT,
> and the C code base board support will be removed
> if DT support is completed.
> Current driver registration method which needs platform data
> and which is not shared complicates codes.
> This means legacy C code cleanup after DT supporting
> will be more complicated
> This patch registers it on board code as cleanup C code
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
I cannot approve this patch. I see it as nothing other as pointless churn.
My opinion probably doesn't matter in the light of Magnus' desire to get it
merged but I'm still clinging to it.
WBR, Sergei
next prev parent reply other threads:[~2013-07-26 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 7:35 [PATCH 6/6 v2] ARM: shmobile: r8a7779: cleanup registration of usb phy Kuninori Morimoto
2013-07-26 13:14 ` Sergei Shtylyov [this message]
2013-07-30 2:39 ` Simon Horman
2013-07-30 2:44 ` Simon Horman
2013-07-30 2:47 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F27648.5060405@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).