[PATCH 5/6 v2] ARM: shmobile: r8a7778: cleanup registration of hspi

[PATCH 5/6 v2] ARM: shmobile: r8a7778: cleanup registration of hspi

[Kuninori Morimoto]

sh-hspi driver which doesn't need platform data at the time of
registration can be registerd on SoC.
And, registering these drivers in the SoC code can avoid
unwanted device numbering issue.
(ex. the hspi2 device number will be spi.0 if hspi2 only registered)
This patch registers it on SoC code as cleanup C code

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
 - based on renesas-devel-20130726
 - update git log

 arch/arm/mach-shmobile/board-bockw.c          |    1 -
 arch/arm/mach-shmobile/include/mach/r8a7778.h |    1 -
 arch/arm/mach-shmobile/setup-r8a7778.c        |    5 ++++-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-bockw.c b/arch/arm/mach-shmobile/board-bockw.c
index d7d3427..b6f3d2f 100644
--- a/arch/arm/mach-shmobile/board-bockw.c
+++ b/arch/arm/mach-shmobile/board-bockw.c
@@ -200,7 +200,6 @@ static void __init bockw_init(void)
 	r8a7778_init_irq_extpin(1);
 	r8a7778_add_standard_devices();
 	r8a7778_add_ether_device(&ether_platform_data);
-	r8a7778_add_hspi_device(0);
 
 	i2c_register_board_info(0, i2c0_devices,
 				ARRAY_SIZE(i2c0_devices));
diff --git a/arch/arm/mach-shmobile/include/mach/r8a7778.h b/arch/arm/mach-shmobile/include/mach/r8a7778.h
index 9874511..41fd6da 100644
--- a/arch/arm/mach-shmobile/include/mach/r8a7778.h
+++ b/arch/arm/mach-shmobile/include/mach/r8a7778.h
@@ -23,7 +23,6 @@
 extern void r8a7778_add_standard_devices(void);
 extern void r8a7778_add_standard_devices_dt(void);
 extern void r8a7778_add_ether_device(struct sh_eth_plat_data *pdata);
-extern void r8a7778_add_hspi_device(int id);
 extern void r8a7778_add_dt_devices(void);
 
 extern void r8a7778_init_late(void);
diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c b/arch/arm/mach-shmobile/setup-r8a7778.c
index e975fcc1..6ac527a 100644
--- a/arch/arm/mach-shmobile/setup-r8a7778.c
+++ b/arch/arm/mach-shmobile/setup-r8a7778.c
@@ -272,7 +272,7 @@ static struct resource hspi_resources[] __initdata = {
 	DEFINE_RES_IRQ(gic_iid(0x75)),
 };
 
-void __init r8a7778_add_hspi_device(int id)
+void __init r8a7778_register_hspi(int id)
 {
 	BUG_ON(id < 0 || id > 2);
 
@@ -307,6 +307,9 @@ void __init r8a7778_add_dt_devices(void)
 	r8a7778_register_i2c(1);
 	r8a7778_register_i2c(2);
 	r8a7778_register_i2c(3);
+	r8a7778_register_hspi(0);
+	r8a7778_register_hspi(1);
+	r8a7778_register_hspi(2);
 }
 
 void __init r8a7778_add_standard_devices(void)
-- 
1.7.9.5

Re: [PATCH 5/6 v2] ARM: shmobile: r8a7778: cleanup registration of hspi

[Sergei Shtylyov]

Hello.

On 26-07-2013 11:35, Kuninori Morimoto wrote:

> sh-hspi driver which doesn't need platform data at the time of
> registration can be registerd on SoC.

    I repeat my question about the pinmux settings.

> And, registering these drivers in the SoC code can avoid
> unwanted device numbering issue.
> (ex. the hspi2 device number will be spi.0 if hspi2 only registered)

    This IMHO is a non-issue.

> This patch registers it on SoC code as cleanup C code

    Why not call the patch ARM: shmobile: r8a7778: register HSPI in SoC code" 
then?

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

WBR, Sergei

Re: [PATCH 5/6 v2] ARM: shmobile: r8a7778: cleanup registration of hspi

[Simon Horman]

On Fri, Jul 26, 2013 at 05:18:59PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 26-07-2013 11:35, Kuninori Morimoto wrote:
> 
> >sh-hspi driver which doesn't need platform data at the time of
> >registration can be registerd on SoC.
> 
>    I repeat my question about the pinmux settings.

I am holding off until I understand the answer to that question
in relation to "ARM: shmobile: r8a7778: cleanup registration of i2c".

> 
> >And, registering these drivers in the SoC code can avoid
> >unwanted device numbering issue.
> >(ex. the hspi2 device number will be spi.0 if hspi2 only registered)
> 
>    This IMHO is a non-issue.
> 
> >This patch registers it on SoC code as cleanup C code
> 
>    Why not call the patch ARM: shmobile: r8a7778: register HSPI in
> SoC code" then?