linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: shmobile: bockw: add SDHI0 support
Date: Fri, 26 Jul 2013 22:38:58 +0000	[thread overview]
Message-ID: <51F2FA82.2050802@cogentembedded.com> (raw)
In-Reply-To: <878v4henwe.wl%kuninori.morimoto.gx@renesas.com>

Hello.

On 04/17/2013 09:17 AM, Kuninori Morimoto wrote:

> This patch is directly accessing to PUPR4 register which can
> control SDHI0 CD/WP pin pull-up setting.
> It should be replaced in the future.

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>   arch/arm/mach-shmobile/board-bockw.c |   29 +++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)

> diff --git a/arch/arm/mach-shmobile/board-bockw.c b/arch/arm/mach-shmobile/board-bockw.c
> index 4d65715..2b6103e 100644
> --- a/arch/arm/mach-shmobile/board-bockw.c
> +++ b/arch/arm/mach-shmobile/board-bockw.c
[...]
>   static const struct pinctrl_map bockw_pinctrl_map[] = {
>   	/* SCIF0 */
>   	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
>   				  "scif0_data_a", "scif0"),
>   	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
>   				  "scif0_ctrl", "scif0"),
> +	/* SDHI0 */
> +	PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
> +				  "sdhi0", "sdhi0"),
>   };

    These SDHI0 data above don't match drivers/pinctrl/sh-pfc/pfc-r8a7778.c 
and cause this message:

sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"

    I'm not sure but maybe because of this SD card can't be detected.

WBR, Sergei


  parent reply	other threads:[~2013-07-26 22:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17  5:17 [PATCH 5/6] ARM: shmobile: bockw: add SDHI0 support Kuninori Morimoto
2013-04-18 12:10 ` Simon Horman
2013-07-26 22:38 ` Sergei Shtylyov [this message]
2013-07-31  0:22 ` Simon Horman
2013-07-31  6:14 ` Kuninori Morimoto
2013-07-31  6:39 ` Simon Horman
2013-07-31 12:09 ` Sergei Shtylyov
2013-08-01  7:58 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F2FA82.2050802@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).