* [PATCH] ml86v7667: override default field interlace order
@ 2013-07-15 19:12 Sergei Shtylyov
2013-07-25 7:32 ` Katsuya MATSUBARA
2013-07-27 22:20 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-07-15 19:12 UTC (permalink / raw)
To: mchehab, linux-media, hverkuil; +Cc: matsu, linux-sh, vladimir.barinov
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
ML86V7667 always transmits top field first for both PAL and NTSC -- that makes
application incorrectly treat interlaced fields when relying on the standard.
Hence we must set V4L2_FIELD_INTERLACED_TB format explicitly.
Reported-by: Katsuya MATSUBARA <matsu@igel.co.jp>
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
[Sergei: added a comment.]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against the 'media_tree.git' repo.
drivers/media/i2c/ml86v7667.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: media_tree/drivers/media/i2c/ml86v7667.c
=================================--- media_tree.orig/drivers/media/i2c/ml86v7667.c
+++ media_tree/drivers/media/i2c/ml86v7667.c
@@ -209,7 +209,8 @@ static int ml86v7667_mbus_fmt(struct v4l
fmt->code = V4L2_MBUS_FMT_YUYV8_2X8;
fmt->colorspace = V4L2_COLORSPACE_SMPTE170M;
- fmt->field = V4L2_FIELD_INTERLACED;
+ /* The top field is always transferred first by the chip */
+ fmt->field = V4L2_FIELD_INTERLACED_TB;
fmt->width = 720;
fmt->height = priv->std & V4L2_STD_525_60 ? 480 : 576;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ml86v7667: override default field interlace order
2013-07-15 19:12 [PATCH] ml86v7667: override default field interlace order Sergei Shtylyov
@ 2013-07-25 7:32 ` Katsuya MATSUBARA
2013-07-27 22:20 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Katsuya MATSUBARA @ 2013-07-25 7:32 UTC (permalink / raw)
To: sergei.shtylyov
Cc: mchehab, linux-media, hverkuil, linux-sh, vladimir.barinov
Hi Vladimir,
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: [PATCH] ml86v7667: override default field interlace order
Date: Mon, 15 Jul 2013 23:12:21 +0400
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> ML86V7667 always transmits top field first for both PAL and NTSC -- that makes
> application incorrectly treat interlaced fields when relying on the standard.
> Hence we must set V4L2_FIELD_INTERLACED_TB format explicitly.
>
> Reported-by: Katsuya MATSUBARA <matsu@igel.co.jp>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: added a comment.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
(snip)
I made sure that it works well on the Renesas BOCK-W board.
Tested-by: Katsuya MATSUBARA <matsu@igel.co.jp>
---
Katsuya Matsubara / IGEL Co., Ltd
matsu@igel.co.jp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ml86v7667: override default field interlace order
2013-07-15 19:12 [PATCH] ml86v7667: override default field interlace order Sergei Shtylyov
2013-07-25 7:32 ` Katsuya MATSUBARA
@ 2013-07-27 22:20 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-07-27 22:20 UTC (permalink / raw)
To: mchehab, linux-media, hverkuil; +Cc: matsu, linux-sh, vladimir.barinov
Hello.
On 15.07.2013 23:12, I wrote:
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ML86V7667 always transmits top field first for both PAL and NTSC -- that makes
> application incorrectly treat interlaced fields when relying on the standard.
> Hence we must set V4L2_FIELD_INTERLACED_TB format explicitly.
> Reported-by: Katsuya MATSUBARA <matsu@igel.co.jp>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: added a comment.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
> This patch is against the 'media_tree.git' repo.
I forgot to mention that it was against the 'fixes' branch, and we
intended it as a fix (I'm seeing this patch committed to the 'master' branch).
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-27 22:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-15 19:12 [PATCH] ml86v7667: override default field interlace order Sergei Shtylyov
2013-07-25 7:32 ` Katsuya MATSUBARA
2013-07-27 22:20 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).