From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-mmc@vger.kernel.org, g.liakhovetski@gmx.de,
ian@mnementh.co.uk, cjb@laptop.org
Cc: linux-sh@vger.kernel.org, max.filippov@cogentembedded.com
Subject: Re: [PATCH] tmio_mmc_dma: fix PIO fallback on SDHI
Date: Thu, 01 Aug 2013 21:26:06 +0000 [thread overview]
Message-ID: <51FAD26E.2020704@cogentembedded.com> (raw)
In-Reply-To: <201308020117.17897.sergei.shtylyov@cogentembedded.com>
Hello.
On 08/02/2013 01:17 AM, Sergei Shtylyov wrote:
> I'm testing SH-Mobile SDHI driver in DMA mode with a new DMA controller using
> 'bonnie++' and getting DMA error after which the tmio_mmc_dma.c code falls back
> to PIO but all commands time out after that. It turned out that the fallback
> code calls tmio_mmc_enable_dma() with RX/TX channels already freed and pointers
> to them cleared, so that the function bails out early instead of clearing the
> DMA bit in the CTL_DMA_ENABLE register. Fixing the RX/TX channel check so that
> it takes place only when enabling DMA helps with the PIO fallback.
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Forgot to mark the patch for stable. The bug was introduced by commit
162f43e31c5a376ec16336e5d0ac973373d54c89 (mmc: tmio: fix a deadlock) back in
2011 -- should probably have mentioned that in the changelog too.
WBR, Sergei
next prev parent reply other threads:[~2013-08-01 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 21:17 [PATCH] tmio_mmc_dma: fix PIO fallback on SDHI Sergei Shtylyov
2013-08-01 21:26 ` Sergei Shtylyov [this message]
2013-08-02 11:35 ` Guennadi Liakhovetski
2013-08-02 18:10 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FAD26E.2020704@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=max.filippov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).