From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/5] ARM: shmobile: r8a7779: Add DU support
Date: Wed, 07 Aug 2013 17:20:54 +0000 [thread overview]
Message-ID: <520281F6.2000900@cogentembedded.com> (raw)
In-Reply-To: <1375892397-5822-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 08/07/2013 08:19 PM, Laurent Pinchart wrote:
> Add a function to register the DU device with board-specific platform
> data. The DU device is named rcar-du-r8a7779, fix the clock entry
> accordingly.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
[...]
> diff --git a/arch/arm/mach-shmobile/include/mach/r8a7779.h b/arch/arm/mach-shmobile/include/mach/r8a7779.h
> index f08d6ec..83c47a2 100644
> --- a/arch/arm/mach-shmobile/include/mach/r8a7779.h
> +++ b/arch/arm/mach-shmobile/include/mach/r8a7779.h
> @@ -6,6 +6,7 @@
> #include <linux/sh_eth.h>
>
> struct platform_device;
> +struct rcar_du_platform_data;
>
> struct r8a7779_pm_ch {
> unsigned long chan_offs;
> @@ -31,6 +32,7 @@ extern void r8a7779_earlytimer_init(void);
> extern void r8a7779_add_early_devices(void);
> extern void r8a7779_add_standard_devices(void);
> extern void r8a7779_add_standard_devices_dt(void);
> +extern void r8a7779_add_du_device(struct rcar_du_platform_data *pdata);
> extern void r8a7779_add_ether_device(struct sh_eth_plat_data *pdata);
> extern void r8a7779_init_late(void);
> extern void r8a7779_clock_init(void);
> diff --git a/arch/arm/mach-shmobile/setup-r8a7779.c b/arch/arm/mach-shmobile/setup-r8a7779.c
> index 6a99333..c587fc9 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7779.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7779.c
> @@ -27,6 +27,7 @@
> #include <linux/of_platform.h>
> #include <linux/platform_data/gpio-rcar.h>
> #include <linux/platform_data/irq-renesas-intc-irqpin.h>
> +#include <linux/platform_data/rcar-du.h>
Why not just include it in the r8a7779.h?
> #include <linux/platform_device.h>
> #include <linux/delay.h>
> #include <linux/input.h>
> @@ -605,6 +606,12 @@ static struct resource ether_resources[] __initdata = {
> },
> };
>
> +/* DU */
> +static struct resource du_resources[] = {
Should be annotated with '__initdata'.
> + DEFINE_RES_MEM(0xfff80000, 0x40000),
> + DEFINE_RES_IRQ(gic_iid(0x3f)),
> +};
> +
WBR, Sergei
next prev parent reply other threads:[~2013-08-07 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 16:19 [PATCH 1/5] ARM: shmobile: r8a7779: Add DU support Laurent Pinchart
2013-08-07 17:20 ` Sergei Shtylyov [this message]
2013-08-07 22:19 ` Laurent Pinchart
2013-08-07 22:42 ` Sergei Shtylyov
2013-08-08 0:12 ` Kuninori Morimoto
2013-08-08 0:24 ` Simon Horman
2013-08-08 0:27 ` Laurent Pinchart
2013-08-08 0:28 ` Laurent Pinchart
2013-08-08 0:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520281F6.2000900@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).