From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/9] ARM: shmobile: r8a7790: Constify platform data and resources
Date: Thu, 08 Aug 2013 11:11:39 +0000 [thread overview]
Message-ID: <52037CEB.2020206@cogentembedded.com> (raw)
In-Reply-To: <1375916192-22647-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hello.
On 08-08-2013 2:56, Laurent Pinchart wrote:
> Platform data and resources for core devices are kmemdup()ed when the
> corresponding devices are registered and can thus be declared as const.
> Do so.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/setup-r8a7790.c | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)
> diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c
> index d0f5c9f..988266e 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7790.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7790.c
> @@ -31,17 +31,18 @@
> #include <mach/r8a7790.h>
> #include <asm/mach/arch.h>
>
> -static struct resource pfc_resources[] __initdata = {
> +static const struct resource pfc_resources[] __initdata = {
I think *const* data should be annotated with '__initconst', no?
WBR, Sergei
next prev parent reply other threads:[~2013-08-08 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 22:56 [PATCH v2 2/9] ARM: shmobile: r8a7790: Constify platform data and resources Laurent Pinchart
2013-08-08 11:11 ` Sergei Shtylyov [this message]
2013-08-08 11:22 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52037CEB.2020206@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).