From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC 06/10] ARM: shmobile: r8a7790: add I2C clock
Date: Fri, 30 Aug 2013 17:31:30 +0000 [thread overview]
Message-ID: <5220D6F2.7040404@cogentembedded.com> (raw)
In-Reply-To: <1377866264-21110-7-git-send-email-ulrich.hecht@gmail.com>
Hello.
On 08/30/2013 04:37 PM, Ulrich Hecht wrote:
> From: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> This patch add clock for I2C bus.
> Signed-off-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> ---
> arch/arm/mach-shmobile/clock-r8a7790.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
> index d99b87b..05cd34b 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7790.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7790.c
[...]
> @@ -181,6 +182,7 @@ static struct clk div6_clks[DIV6_NR] = {
>
> /* MSTP */
> enum {
> + MSTP931, MSTP930, MSTP929, MSTP928,
Please break the line after "MSTP930,".
[...]
> @@ -286,6 +293,10 @@ static struct clk_lookup lookups[] = {
> CLKDEV_DEV_ID("ee220000.mmcif", &mstp_clks[MSTP305]),
> CLKDEV_DEV_ID("sh_mmcif.1", &mstp_clks[MSTP305]),
> CLKDEV_DEV_ID("sh_cmt.0", &mstp_clks[MSTP124]),
> + CLKDEV_DEV_ID("i2c-rcar.0", &mstp_clks[MSTP931]),
> + CLKDEV_DEV_ID("i2c-rcar.1", &mstp_clks[MSTP930]),
> + CLKDEV_DEV_ID("i2c-rcar.2", &mstp_clks[MSTP929]),
> + CLKDEV_DEV_ID("i2c-rcar.3", &mstp_clks[MSTP928]),
These should be sorted downwards by MSTPxxx index, no?
WBR, Sergei
next prev parent reply other threads:[~2013-08-30 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 12:37 [RFC 06/10] ARM: shmobile: r8a7790: add I2C clock Ulrich Hecht
2013-08-30 17:31 ` Sergei Shtylyov [this message]
2013-09-03 7:21 ` Ulrich Hecht
2013-09-03 12:21 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5220D6F2.7040404@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).