From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
Date: Wed, 11 Sep 2013 12:14:28 +0000 [thread overview]
Message-ID: <52305EA4.1060902@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoRKFoS9tehteDGaTUYJ8fSBqAYJJDiLxZmoNB9W0N+Mpg@mail.gmail.com>
Hello.
On 09-09-2013 11:05, Magnus Damm wrote:
>> Add the Ether pin group to bockw_pinctrl_map[].
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>> =================================>> --- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
>> +++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>> @@ -29,6 +29,9 @@
>> */
>>
>> static const struct pinctrl_map bockw_pinctrl_map[] = {
>> + /* Ether */
>> + PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
>> + "ether_rmii", "ether"),
>> /* SCIF0 */
>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
>> "scif0_data_a", "scif0"),
> Hi Sergei,
> Thanks for your patches. In general I think your series looks fine. I
> have a single comment, and that's about the pinctrl-related hunk
> above. I can see that this patch is for DT reference for Bock-W, so I
> expect the code to be in DT. Do you have any plans to use DT to
> describe the pinmux bits? Perhaps you have some incremental patch
> planned?
No, I just repeated what I saw mechanically. Now I'm seeing some evidence
that PFC driver supports the device tree, so I probably need to redo the
patchset... let me study this question better.
> Cheers,
> / magnus
WBR, Sergei
next prev parent reply other threads:[~2013-09-11 12:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-07 0:23 [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Sergei Shtylyov
2013-09-07 0:26 ` [PATCH v2 1/4] ARM: shmobile: r8a7778: add Ether DT support Sergei Shtylyov
2013-09-07 0:27 ` [PATCH v2 2/4] ARM: shmobile: r8a7778: add Ether clock for DT case Sergei Shtylyov
2013-09-07 0:29 ` [PATCH v2 3/4] ARM: shmobile: bockw-reference: add Ether DT support Sergei Shtylyov
2013-09-07 0:31 ` [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings Sergei Shtylyov
2013-09-09 7:05 ` Magnus Damm
2013-09-11 12:14 ` Sergei Shtylyov [this message]
2013-09-25 4:47 ` Simon Horman
2013-09-25 15:54 ` Sergei Shtylyov
2013-09-26 1:51 ` Simon Horman
2013-09-26 20:44 ` Sergei Shtylyov
2013-09-27 4:38 ` Simon Horman
2013-10-16 21:56 ` Sergei Shtylyov
2013-10-17 6:06 ` Simon Horman
2013-10-17 6:07 ` Simon Horman
2013-09-09 0:11 ` [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Simon Horman
2013-09-09 0:48 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52305EA4.1060902@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).