From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Date: Thu, 26 Sep 2013 10:18:47 +0000 Subject: Re: [PATCH 1/6] clocksource: em_sti: convert to clk_prepare/unprepare Message-Id: <52440A07.4050101@linaro.org> List-Id: References: <52410F86.4040301@renesas.com> <20130924130924.61d4ecedf3d4fca5952d55fc@ops.dti.ne.jp> <20130924044236.GC3619@verge.net.au> In-Reply-To: <20130924044236.GC3619@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Simon Horman , takasi-y@ops.dti.ne.jp Cc: SH-Linux , Magnus Damm , ben.dooks@codethink.co.uk, Shinya Kuribayashi , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, Paul Mundt , Mike Turquette , linux-kernel@vger.kernel.org, Thomas Gleixner On 09/24/2013 06:42 AM, Simon Horman wrote: > [ CCed Daniel Lezcano and Thomas Gleixner, the clocksource maintainers ] > > On Tue, Sep 24, 2013 at 01:09:24PM +0900, takasi-y@ops.dti.ne.jp wrote: >> From: Shinya Kuribayashi >> >> Add calls to clk_prepare and unprepare so that EMMA Mobile EV2 can >> migrate to the common clock framework. >> >> Signed-off-by: Shinya Kuribayashi I am not a clk framework expert but at the first glance sounds correct. Acked-by: Daniel Lezcano >> --- >> drivers/clocksource/em_sti.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c >> index 3a5909c..9d17083 100644 >> --- a/drivers/clocksource/em_sti.c >> +++ b/drivers/clocksource/em_sti.c >> @@ -78,7 +78,7 @@ static int em_sti_enable(struct em_sti_priv *p) >> int ret; >> >> /* enable clock */ >> - ret =3D clk_enable(p->clk); >> + ret =3D clk_prepare_enable(p->clk); >> if (ret) { >> dev_err(&p->pdev->dev, "cannot enable clock\n"); >> return ret; >> @@ -107,7 +107,7 @@ static void em_sti_disable(struct em_sti_priv *p) >> em_sti_write(p, STI_INTENCLR, 3); >> >> /* stop clock */ >> - clk_disable(p->clk); >> + clk_disable_unprepare(p->clk); >> } >> >> static cycle_t em_sti_count(struct em_sti_priv *p) >> -- >> 1.8.1.5 >> --=20 Linaro.org =E2=94=82 Open source software for AR= M SoCs Follow Linaro: Facebook | Twitter | Blog