From: Richard Weinberger <richard@nod.at>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Michal Marek <mmarek@suse.cz>, Ralf Baechle <ralf@linux-mips.org>,
Paul Mundt <lethal@linux-sh.org>, Jeff Dike <jdike@addtoit.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH 2/8] um: Do not use SUBARCH
Date: Thu, 26 Sep 2013 15:04:13 +0000 [thread overview]
Message-ID: <52444CED.40401@nod.at> (raw)
In-Reply-To: <CALkWK0kcd03t9W4O24wiVBQ8SZQ8ZcrbvQaUkcCm+y5n=d1wPw@mail.gmail.com>
Am 26.09.2013 16:36, schrieb Ramkumar Ramachandra:
> Richard Weinberger wrote:
>>> Sorry for chiming in, but... what about cross compiling?
>>> SUBARCH=x86 should give you a 32-bit ia32 kernel, right?
>>
>> Correct.
>> Users expect from SUBARCH=x86 a i386 32bit UML kernel.
>
> This is an insane expectation. This is kernel convention (it has
> nothing to do with uml):
Hmm, looks like I missed commit ffee0de411, thanks for pointing that out.
Before ffee0de411 "make defconfig ARCH=x86" produced a 32bit defconfig.
Now it produces a x86_64 defconfig.
As UML is a variant of x86 it makes not much sense to do things the other
way around even if we break assumptions.
And, of course, this makes your patch valid.
Can you also please ensure that your new defconfigs are minimal?
See make savedefconfig.
Thanks,
//richard
next prev parent reply other threads:[~2013-09-26 15:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:19 [RFC] Get rid of SUBARCH Richard Weinberger
2013-08-21 8:19 ` [PATCH 1/8] um: Create defconfigs for i386 and x86_64 Richard Weinberger
2013-08-22 4:55 ` Stephen Rothwell
2013-09-26 10:32 ` Ramkumar Ramachandra
2013-09-26 10:35 ` Richard Weinberger
2013-09-26 11:58 ` Ramkumar Ramachandra
2013-09-26 12:04 ` Richard Weinberger
2013-09-27 9:22 ` Toralf Förster
2013-09-27 9:26 ` Richard Weinberger
2013-08-21 8:19 ` [PATCH 2/8] um: Do not use SUBARCH Richard Weinberger
2013-09-26 10:52 ` Ramkumar Ramachandra
2013-09-26 10:44 ` Richard Weinberger
2013-09-26 10:54 ` Ramkumar Ramachandra
2013-09-26 11:01 ` Richard Weinberger
2013-09-26 11:55 ` Ramkumar Ramachandra
2013-09-26 11:56 ` Richard Weinberger
2013-09-26 12:12 ` Ramkumar Ramachandra
2013-09-26 13:25 ` Ramkumar Ramachandra
2013-09-26 13:26 ` Geert Uytterhoeven
2013-09-26 13:58 ` Ramkumar Ramachandra
2013-09-26 14:24 ` Richard Weinberger
2013-09-26 14:48 ` Ramkumar Ramachandra
2013-09-26 15:04 ` Richard Weinberger [this message]
2013-09-26 16:18 ` Ramkumar Ramachandra
2013-09-26 17:10 ` Richard Weinberger
2013-08-21 8:19 ` [PATCH 3/8] um: Remove old defconfig Richard Weinberger
2013-08-21 8:19 ` [PATCH 4/8] m68k: Do not use SUBARCH Richard Weinberger
2013-08-21 8:19 ` [PATCH 5/8] sh: " Richard Weinberger
2013-08-21 8:19 ` [PATCH 6/8] mips: " Richard Weinberger
2013-08-21 8:19 ` [PATCH 7/8] unicore32: " Richard Weinberger
2013-08-21 8:19 ` [PATCH 8/8] Makefile: Remove SUBARCH Richard Weinberger
2013-08-21 12:07 ` [RFC] Get rid of SUBARCH Geert Uytterhoeven
2013-08-21 12:16 ` Richard Weinberger
2013-08-21 17:25 ` Rob Landley
2013-08-21 19:51 ` Sam Ravnborg
2013-08-22 12:58 ` Geert Uytterhoeven
2013-08-22 20:41 ` Rob Landley
2013-08-22 20:55 ` David Daney
2013-08-22 21:32 ` Rob Landley
2013-08-21 12:53 ` Thorsten Glaser
2013-08-21 12:58 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52444CED.40401@nod.at \
--to=richard@nod.at \
--cc=artagnon@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).