From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Simon Horman <horms@verge.net.au>,
Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Subject: Re: [PATCH v2 5/5] ARM: shmobile: lager: (DEVEL) add CPUFreq support
Date: Thu, 26 Sep 2013 18:23:22 +0000 [thread overview]
Message-ID: <52447B9A.5090805@cogentembedded.com> (raw)
In-Reply-To: <1380216060-14506-6-git-send-email-g.liakhovetski@gmx.de>
Hello.
On 09/26/2013 09:21 PM, Guennadi Liakhovetski wrote:
> The Lager board uses a DA9210 voltage regulator to supply DVFS power to the
> CA15 cores on the r8a7790 SoC. This patch adds CPUFreq support for that
> board using the cpufreq-cpu0 driver.
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
> v2: added 'status = "okay";' to the i2c bus
> arch/arm/boot/dts/r8a7790-lager-reference.dts | 33 ++++++++++++++++++++++++
> arch/arm/mach-shmobile/board-lager-reference.c | 4 ++-
> 2 files changed, 36 insertions(+), 1 deletions(-)
> diff --git a/arch/arm/boot/dts/r8a7790-lager-reference.dts b/arch/arm/boot/dts/r8a7790-lager-reference.dts
> index c462ef1..1ce0a97 100644
> --- a/arch/arm/boot/dts/r8a7790-lager-reference.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager-reference.dts
> @@ -43,3 +43,36 @@
> };
> };
> };
> +
> +&i2c3 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c3_pins>;
> +
> + vdd_dvfs: da9210@68 {
ePAPR spec [1] says: "The name of a node should be somewhat generic,
reflecting the function of the device and not its precise programming model."
So I suggest "regulator" instead of "da9210".
> + compatible = "diasemi,da9210";
> + reg = <0x68>;
> +
> + regulator-min-microvolt = <900000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +};
[...]
> diff --git a/arch/arm/mach-shmobile/board-lager-reference.c b/arch/arm/mach-shmobile/board-lager-reference.c
> index 1a1a4a8..2bc8bae 100644
> --- a/arch/arm/mach-shmobile/board-lager-reference.c
> +++ b/arch/arm/mach-shmobile/board-lager-reference.c
[...]
> @@ -29,7 +30,8 @@ static void __init lager_add_standard_devices(void)
> r8a7790_clock_init();
>
> r8a7790_add_dt_devices();
> - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
Hm, "drove-by" cleanup?
> + platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
> }
>
> static const char *lager_boards_compat_dt[] __initdata = {
Shouldn't the patch be split into .dts and .c parts, I wonder?
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
next prev parent reply other threads:[~2013-09-26 18:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 17:20 [PATCH v2 0/5] ARM: shmobile: CPUFreq support on Lager Guennadi Liakhovetski
2013-09-26 17:20 ` [PATCH v2 1/5] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface Guennadi Liakhovetski
2013-09-27 0:09 ` Laurent Pinchart
2013-09-26 17:20 ` [PATCH v2 2/5] ARM: shmobile: r8a7790: add I2C clocks and aliases for the DT mode Guennadi Liakhovetski
2013-09-27 4:49 ` Simon Horman
2013-09-26 17:20 ` [PATCH v2 3/5] ARM: shmobile: r8a7790: add I2C DT nodes Guennadi Liakhovetski
2013-09-27 4:48 ` Simon Horman
2013-09-26 17:20 ` [PATCH v2 4/5] ARM: shmobile: r8a7790: add CPUFreq clock support Guennadi Liakhovetski
2013-09-26 17:21 ` [PATCH v2 5/5] ARM: shmobile: lager: (DEVEL) add CPUFreq support Guennadi Liakhovetski
2013-09-26 18:23 ` Sergei Shtylyov [this message]
2013-09-27 8:37 ` Guennadi Liakhovetski
2013-09-26 23:59 ` Laurent Pinchart
2013-09-27 6:32 ` Guennadi Liakhovetski
2013-09-30 15:25 ` [PATCH v2 0/5] ARM: shmobile: CPUFreq support on Lager Guennadi Liakhovetski
2013-09-30 23:53 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52447B9A.5090805@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=g.liakhovetski+renesas@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).