From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de,
linux-can@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] can: add Renesas R-Car CAN driver
Date: Sat, 28 Sep 2013 00:52:59 +0000 [thread overview]
Message-ID: <5246286B.6020905@cogentembedded.com> (raw)
In-Reply-To: <20130927174518.2ee83214@nehalam.linuxnetplumber.net>
Hello.
On 09/28/2013 04:45 AM, Stephen Hemminger wrote:
>> + stats->rx_bytes += cf->can_dlc;
>> +}
>> +
>> +static irqreturn_t rcar_can_interrupt(int irq, void *dev_id)
>> +{
>> + struct net_device *ndev = (struct net_device *)dev_id;
>> + struct rcar_can_priv *priv = netdev_priv(ndev);
>> + struct net_device_stats *stats = &ndev->stats;
>> + u8 isr;
>> +
>> + isr = rcar_can_readb(priv, RCAR_CAN_ISR);
>> + if (isr & ISR_ERSF)
>> + rcar_can_error(ndev);
> IRQ handler should return IRQ_NONE if not for this device.
> Most devices this is true if isr is 0.
Hm, totally overlooked that... :-/
> Also should check for hot-plug case where device interrupt occurs
> but see's all-ones on the bus.
Hotplug is not possible with this SoC device.
WBR, Sergei
next prev parent reply other threads:[~2013-09-28 0:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 22:11 [PATCH] can: add Renesas R-Car CAN driver Sergei Shtylyov
2013-09-28 0:40 ` Joe Perches
2013-09-28 0:45 ` Stephen Hemminger
2013-09-28 0:52 ` Sergei Shtylyov [this message]
2013-09-29 19:03 ` Marc Kleine-Budde
2013-10-17 21:54 ` Sergei Shtylyov
2013-10-02 6:09 ` Wolfgang Grandegger
2013-10-17 22:16 ` Sergei Shtylyov
2013-10-21 19:12 ` Wolfgang Grandegger
2013-11-09 0:02 ` Sergei Shtylyov
2013-11-09 10:53 ` Wolfgang Grandegger
2013-11-09 14:47 ` Wolfgang Grandegger
2013-11-12 20:45 ` Sergei Shtylyov
2013-11-12 22:17 ` Wolfgang Grandegger
2013-10-05 17:57 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5246286B.6020905@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).