From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Brandt <chris.brandt@renesas.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
uli@fpond.eu, Yoshinori Sato <ysato@users.sourceforge.jp>,
Greg KH <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH/RFC 3/4] Revert "serial: sh-sci: Compute the regshift value for SCI ports"
Date: Mon, 06 Aug 2018 14:41:00 +0000 [thread overview]
Message-ID: <5255599.OJHZJSCvpZ@avalon> (raw)
In-Reply-To: <CAMuHMdVMToQsVpUzqnSC-OscNnNfoyOSt47S9Eset3hNPwxtWg@mail.gmail.com>
Hi Geert,
On Monday, 6 August 2018 17:34:34 EEST Geert Uytterhoeven wrote:
> On Mon, Aug 6, 2018 at 4:16 PM Laurent Pinchart wrote:
> > On Monday, 6 August 2018 17:07:54 EEST Geert Uytterhoeven wrote:
> >> This reverts commit dfc80387aefb78161f83732804c6d01c89c24595.
> >>
> >> Deriving the proper regshift value from the register block size is
> >> fragile, as it may have been rounded up.
> >>
> >> Furthermore we will need plat_sci_port.regshift again.
> >
> > Won't this break bisection ? Shouldn't you squash patches 3 and 4 together
> > ?
> >
> > Does this mechanism break anything on non-DT platforms ? If not I'd rather
> > keep it for them, and only use compat strings for DT platforms, to
> > avoiding adding back a platform data field.
>
> Actually I think the original commit broke SCI on H8/300, as regshift should
> be zero on that platform.
> But that was not discovered until recently.
So there are still people booting H3/800 ? :-)
Could we still keep the mechanism for SH and fix H8/300 with special handling
somewhere ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-08-06 14:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 14:07 [PATCH/RFC 0/4] sh-sci : Do not derive regshift from regsize Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 1/4] sh-sci: Use a separate sci_port for earlycon Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 2/4] sh-sci: Take into account regshift to fix earlycon breakage Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 3/4] Revert "serial: sh-sci: Compute the regshift value for SCI ports" Geert Uytterhoeven
2018-08-06 14:16 ` Laurent Pinchart
2018-08-06 14:34 ` Geert Uytterhoeven
2018-08-06 14:41 ` Laurent Pinchart [this message]
2018-08-06 14:52 ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value Geert Uytterhoeven
2018-08-06 14:18 ` Chris Brandt
2018-08-06 14:38 ` Geert Uytterhoeven
2018-08-06 16:10 ` Chris Brandt
2018-08-07 19:24 ` Chris Brandt
2018-08-07 19:37 ` Geert Uytterhoeven
2018-08-07 21:10 ` Chris Brandt
2018-08-08 0:16 ` Chris Brandt
2018-08-08 10:11 ` Geert Uytterhoeven
2018-08-08 10:39 ` Chris Brandt
2018-08-08 11:05 ` Geert Uytterhoeven
2018-08-06 14:37 ` [PATCH/RFC 0/4] sh-sci : Do not derive regshift from regsize Laurent Pinchart
2018-08-06 14:41 ` Laurent Pinchart
2018-08-06 14:41 ` Geert Uytterhoeven
2018-08-08 11:02 ` Geert Uytterhoeven
2018-08-08 11:32 ` Chris Brandt
2018-08-08 20:46 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5255599.OJHZJSCvpZ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=uli@fpond.eu \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).