[PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[Kuninori Morimoto]

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/boot/dts/r8a7778.dtsi |   30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
index 0ff38e6..873eeb9 100644
--- a/arch/arm/boot/dts/r8a7778.dtsi
+++ b/arch/arm/boot/dts/r8a7778.dtsi
@@ -164,4 +164,34 @@
 		interrupts = <0 61 4>;
 		status = "disabled";
 	};
+
+	sdhi0: sdhi@ffe4c000 {
+		compatible = "renesas,sdhi-r8a7778";
+		reg = <0xffe4c000 0x100>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 87 4>;
+		cap-sd-highspeed;
+		cap-sdio-irq;
+		status = "disabled";
+	};
+
+	sdhi1: sdhi@ffe4d000 {
+		compatible = "renesas,sdhi-r8a7778";
+		reg = <0xffe4d000 0x100>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 88 4>;
+		cap-sd-highspeed;
+		cap-sdio-irq;
+		status = "disabled";
+	};
+
+	sdhi2: sdhi@ffe4f000 {
+		compatible = "renesas,sdhi-r8a7778";
+		reg = <0xffe4f000 0x100>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 86 4>;
+		cap-sd-highspeed;
+		cap-sdio-irq;
+		status = "disabled";
+	};
 };
-- 
1.7.9.5

Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[Sergei Shtylyov]

Hello.

On 11-10-2013 8:35, Kuninori Morimoto wrote:

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>   arch/arm/boot/dts/r8a7778.dtsi |   30 ++++++++++++++++++++++++++++++
>   1 file changed, 30 insertions(+)

> diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
> index 0ff38e6..873eeb9 100644
> --- a/arch/arm/boot/dts/r8a7778.dtsi
> +++ b/arch/arm/boot/dts/r8a7778.dtsi
> @@ -164,4 +164,34 @@
>   		interrupts = <0 61 4>;
>   		status = "disabled";
>   	};
> +
> +	sdhi0: sdhi@ffe4c000 {

    ePAPR spec [1] says:

"The name of a node should be somewhat generic, reflecting the function of the 
device and not its precise programming model." So I suggest using "mmc" or 
"sd" instead.

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[Simon Horman]

On Fri, Oct 11, 2013 at 11:26:33PM +0200, Sergei Shtylyov wrote:
> Hello.
> 
> On 11-10-2013 8:35, Kuninori Morimoto wrote:
> 
> >Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >---
> >  arch/arm/boot/dts/r8a7778.dtsi |   30 ++++++++++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> 
> >diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
> >index 0ff38e6..873eeb9 100644
> >--- a/arch/arm/boot/dts/r8a7778.dtsi
> >+++ b/arch/arm/boot/dts/r8a7778.dtsi
> >@@ -164,4 +164,34 @@
> >  		interrupts = <0 61 4>;
> >  		status = "disabled";
> >  	};
> >+
> >+	sdhi0: sdhi@ffe4c000 {
> 
>    ePAPR spec [1] says:
> 
> "The name of a node should be somewhat generic, reflecting the
> function of the device and not its precise programming model." So I
> suggest using "mmc" or "sd" instead.
> 
> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

Morimoto-san,

would it be possible for you to either update this patch or provide a
subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
slight preference for "mmc" but please use your own judgement.

If you could also provide patches to update existing dts/dtsi files
that would be awesome.

Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[Kuninori Morimoto]

Hi Magnus, Simon

> > "The name of a node should be somewhat generic, reflecting the
> > function of the device and not its precise programming model." So I
> > suggest using "mmc" or "sd" instead.
> > 
> > [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
> 
> Morimoto-san,
> 
> would it be possible for you to either update this patch or provide a
> subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
> slight preference for "mmc" but please use your own judgement.
> 
> If you could also provide patches to update existing dts/dtsi files
> that would be awesome.

I see.
But, we already have both SDHI and MMCIF now.
I guess below naming seems good.

 - SDHI  -> sd
 - MMCIF -> mmc

what do you think ?



Best regards
---
Kuninori Morimoto

Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[Kuninori Morimoto]

Hi Simon again

> > > "The name of a node should be somewhat generic, reflecting the
> > > function of the device and not its precise programming model." So I
> > > suggest using "mmc" or "sd" instead.
> > > 
> > > [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
> > 
> > Morimoto-san,
> > 
> > would it be possible for you to either update this patch or provide a
> > subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
> > slight preference for "mmc" but please use your own judgement.
> > 
> > If you could also provide patches to update existing dts/dtsi files
> > that would be awesome.
> 
> I see.
> But, we already have both SDHI and MMCIF now.
> I guess below naming seems good.
> 
>  - SDHI  -> sd
>  - MMCIF -> mmc
> 
> what do you think ?

And, I will send fixup patches for existing dts/dtsi.
Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
or do you want to me v2 patches for these ?

Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[Simon Horman]

On Mon, Oct 14, 2013 at 06:07:31PM -0700, Kuninori Morimoto wrote:
> Hi Simon again
> 
> > > > "The name of a node should be somewhat generic, reflecting the
> > > > function of the device and not its precise programming model." So I
> > > > suggest using "mmc" or "sd" instead.
> > > > 
> > > > [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
> > > 
> > > Morimoto-san,
> > > 
> > > would it be possible for you to either update this patch or provide a
> > > subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
> > > slight preference for "mmc" but please use your own judgement.
> > > 
> > > If you could also provide patches to update existing dts/dtsi files
> > > that would be awesome.
> > 
> > I see.
> > But, we already have both SDHI and MMCIF now.
> > I guess below naming seems good.
> > 
> >  - SDHI  -> sd
> >  - MMCIF -> mmc
> > 
> > what do you think ?

Sounds good.

> And, I will send fixup patches for existing dts/dtsi.
> Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
> or do you want to me v2 patches for these ?

I'm happy to take your current patches as-is and then apply
naming fixes on top.

Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[Kuninori Morimoto]

Hi Simon

> > And, I will send fixup patches for existing dts/dtsi.
> > Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
> > or do you want to me v2 patches for these ?
> 
> I'm happy to take your current patches as-is and then apply
> naming fixes on top.

Cool, thank you


Best regards
---
Kuninori Morimoto

Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI

[Simon Horman]

On Wed, Oct 16, 2013 at 07:51:56PM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > And, I will send fixup patches for existing dts/dtsi.
> > > Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
> > > or do you want to me v2 patches for these ?
> > 
> > I'm happy to take your current patches as-is and then apply
> > naming fixes on top.
> 
> Cool, thank you

Btw, I have taken them. Let me know if I am mistaken.