linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] rcar-hpbdma: add max transfer size
@ 2013-10-17 10:51 Kuninori Morimoto
  2013-10-17 13:02 ` Sergei Shtylyov
  0 siblings, 1 reply; 3+ messages in thread
From: Kuninori Morimoto @ 2013-10-17 10:51 UTC (permalink / raw)
  To: linux-sh

shdma_chan_probe() can set max transfer size,
but it will be PAGE_SIZE with out this patch.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/dma/sh/rcar-hpbdma.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
index ebad845..b1ae8dc 100644
--- a/drivers/dma/sh/rcar-hpbdma.c
+++ b/drivers/dma/sh/rcar-hpbdma.c
@@ -510,6 +510,8 @@ static int hpb_dmae_chan_probe(struct hpb_dmae_device *hpbdev, int id)
 	}
 
 	schan = &new_hpb_chan->shdma_chan;
+	schan->max_xfer_len = HPB_DMA_TCR_MAX + 1;
+
 	shdma_chan_probe(sdev, schan, id);
 
 	if (pdev->id >= 0)
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/3] rcar-hpbdma: add max transfer size
  2013-10-17 10:51 [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto
@ 2013-10-17 13:02 ` Sergei Shtylyov
  0 siblings, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-10-17 13:02 UTC (permalink / raw)
  To: linux-sh

Hello.

On 17-10-2013 14:51, Kuninori Morimoto wrote:

> shdma_chan_probe() can set max transfer size,
> but it will be PAGE_SIZE with out this patch.

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>   drivers/dma/sh/rcar-hpbdma.c |    2 ++
>   1 file changed, 2 insertions(+)

> diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
> index ebad845..b1ae8dc 100644
> --- a/drivers/dma/sh/rcar-hpbdma.c
> +++ b/drivers/dma/sh/rcar-hpbdma.c
> @@ -510,6 +510,8 @@ static int hpb_dmae_chan_probe(struct hpb_dmae_device *hpbdev, int id)
>   	}
>
>   	schan = &new_hpb_chan->shdma_chan;
> +	schan->max_xfer_len = HPB_DMA_TCR_MAX + 1;
> +

    +1 is not correct here, HPB_DMA_TCR_MAX is #define'd as 16 MiB, not 16 MiB 
- 1.

WBR, Sergei


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/3] rcar-hpbdma: add max transfer size
  2013-10-29  6:51 ` Kuninori Morimoto
@ 2013-10-29  6:52   ` Kuninori Morimoto
  0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2013-10-29  6:52 UTC (permalink / raw)
  To: Koul, Vinod
  Cc: Simon, Max Filippov, Magnus, linux-sh, Kuninori Morimoto,
	linux-kernel

shdma_chan_probe() can set max transfer size,
but it will be PAGE_SIZE with out this patch.

Reviewed-by: Max Filippov <max.filippov@cogentembedded.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/dma/sh/rcar-hpbdma.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
index ebad845..496180a 100644
--- a/drivers/dma/sh/rcar-hpbdma.c
+++ b/drivers/dma/sh/rcar-hpbdma.c
@@ -510,6 +510,8 @@ static int hpb_dmae_chan_probe(struct hpb_dmae_device *hpbdev, int id)
 	}
 
 	schan = &new_hpb_chan->shdma_chan;
+	schan->max_xfer_len = HPB_DMA_TCR_MAX;
+
 	shdma_chan_probe(sdev, schan, id);
 
 	if (pdev->id >= 0)
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-29  6:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 10:51 [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto
2013-10-17 13:02 ` Sergei Shtylyov
  -- strict thread matches above, loose matches on Subject: below --
2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches for double plane Kuninori Morimoto
2013-10-29  6:51 ` Kuninori Morimoto
2013-10-29  6:52   ` [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).