From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3] rcar-hpbdma: fixup channel busy check for double plane
Date: Thu, 17 Oct 2013 13:23:28 +0000 [thread overview]
Message-ID: <525FE4D0.2080406@cogentembedded.com> (raw)
In-Reply-To: <87fvs01876.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 17-10-2013 14:51, Kuninori Morimoto wrote:
> The device busy check method is different between
> single and double planes.
> It will always return "busy" without this patch
> if channel used as double plane.
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> drivers/dma/sh/rcar-hpbdma.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
> index 0518135..6fc37b4 100644
> --- a/drivers/dma/sh/rcar-hpbdma.c
> +++ b/drivers/dma/sh/rcar-hpbdma.c
> @@ -388,7 +388,10 @@ static bool hpb_dmae_channel_busy(struct shdma_chan *schan)
> struct hpb_dmae_chan *chan = to_chan(schan);
> u32 dstsr = ch_reg_read(chan, HPB_DMAE_DSTSR);
>
> - return (dstsr & HPB_DMAE_DSTSR_DMSTS) = HPB_DMAE_DSTSR_DMSTS;
> + if (chan->xfer_mode = XFER_DOUBLE)
> + return dstsr & HPB_DMAE_DSTSR_DQSTS;
This bit is not #define'd in the driver. Did you compile this?
WBR, Sergei
next prev parent reply other threads:[~2013-10-17 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 10:51 [PATCH 3/3] rcar-hpbdma: fixup channel busy check for double plane Kuninori Morimoto
2013-10-17 13:23 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches " Kuninori Morimoto
2013-10-29 6:51 ` Kuninori Morimoto
2013-10-29 6:52 ` [PATCH 3/3] rcar-hpbdma: fixup channel busy check " Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525FE4D0.2080406@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).