From: カオ ミン ヒェップ <cm-hiep@jinso.co.jp>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2 v3] ARM: shmobile: r8a7790: add QSPI support
Date: Tue, 22 Oct 2013 01:55:17 +0000 [thread overview]
Message-ID: <5265DB05.5000009@jinso.co.jp> (raw)
In-Reply-To: <1382326020-10558-2-git-send-email-cm-hiep@jinso.co.jp>
Hi Morimoto-san
>>>> /* MSTP */
>>>> enum {
>>>> - MSTP931, MSTP930, MSTP929, MSTP928,
>>>> + MSTP931, MSTP930, MSTP929, MSTP928, MSTP917,
>>> Sorry for not mentioning it before but MSTP917 should be on a line
>>> of its own.
>>>
>> I am not clear your comment yet. Could you please tell me why the
>> MSTP917 should be
>> on a line of its own instead of MSTP9xx.
> It is SH-ARM traditional rule.
> MSTP line should keep like this
>
> MSTP93x, MSTP93y, MSTP93z...
> MSTP92x, MSTP92y, MSTP92z...
> MSTP91x, MSTP91y, MSTP91z...
>
> But, as I already commented, current MSTP9xx line is already broken here.
> # The SoC which has broken MSTP line is not only r8a7790 today,
> # and cleaning these line makes it difficult to backport.
>
> Anyway, sending v4 patch for it is up to Simon.
Thanks, I'll update the patch v4 with Sergei's and your comments to Simon.
Best Regards,
---
Hiep Cao Minh.
prev parent reply other threads:[~2013-10-22 1:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 3:26 [PATCH 1/2 v3] ARM: shmobile: r8a7790: add QSPI support Cao Minh Hiep
2013-10-21 4:46 ` Kuninori Morimoto
2013-10-21 13:13 ` Sergei Shtylyov
2013-10-22 0:52 ` カオ ミン ヒェップ
2013-10-22 1:26 ` Kuninori Morimoto
2013-10-22 1:55 ` カオ ミン ヒェップ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5265DB05.5000009@jinso.co.jp \
--to=cm-hiep@jinso.co.jp \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox