From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7779: cleanup registration of sh_eth
Date: Fri, 01 Nov 2013 12:24:29 +0000 [thread overview]
Message-ID: <52739D7D.40409@cogentembedded.com> (raw)
In-Reply-To: <874n7xylzz.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 01-11-2013 5:00, Kuninori Morimoto wrote:
> sh_eth driver which needs platform data at the time of
> registration is not used.
> Now, ARM/shmobile aims to support DT,
> and the C code base board support will be removed
> if DT support is completed.
> Current driver registration method which needs platform data
> and which is not shared complicates codes.
> This means legacy C code cleanup after DT supporting
> will be more complicated
> This patch registers it on board code as cleanup C code
What? Where are you doing that?
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/include/mach/r8a7779.h | 2 --
> arch/arm/mach-shmobile/setup-r8a7779.c | 20 --------------------
> 2 files changed, 22 deletions(-)
> diff --git a/arch/arm/mach-shmobile/include/mach/r8a7779.h b/arch/arm/mach-shmobile/include/mach/r8a7779.h
> index 1cab247..5014145 100644
> --- a/arch/arm/mach-shmobile/include/mach/r8a7779.h
> +++ b/arch/arm/mach-shmobile/include/mach/r8a7779.h
> @@ -3,7 +3,6 @@
>
> #include <linux/sh_clk.h>
> #include <linux/pm_domain.h>
> -#include <linux/sh_eth.h>
>
> /* HPB-DMA slave IDs */
> enum {
> @@ -39,7 +38,6 @@ extern void r8a7779_earlytimer_init(void);
> extern void r8a7779_add_early_devices(void);
> extern void r8a7779_add_standard_devices(void);
> extern void r8a7779_add_standard_devices_dt(void);
> -extern void r8a7779_add_ether_device(struct sh_eth_plat_data *pdata);
> extern void r8a7779_init_late(void);
> extern void r8a7779_clock_init(void);
> extern void r8a7779_pinmux_init(void);
> diff --git a/arch/arm/mach-shmobile/setup-r8a7779.c b/arch/arm/mach-shmobile/setup-r8a7779.c
> index 51a43c5..8f94531 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7779.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7779.c
> @@ -598,18 +598,6 @@ static struct platform_device ohci1_device = {
> .resource = ohci1_resources,
> };
>
> -/* Ether */
> -static struct resource ether_resources[] __initdata = {
> - {
> - .start = 0xfde00000,
> - .end = 0xfde003ff,
> - .flags = IORESOURCE_MEM,
> - }, {
> - .start = gic_iid(0xb4),
> - .flags = IORESOURCE_IRQ,
> - },
> -};
> -
> /* HPB-DMA */
>
> /* Asynchronous mode register bits */
> @@ -798,14 +786,6 @@ void __init r8a7779_add_standard_devices(void)
> r8a7779_register_hpb_dmae();
> }
>
> -void __init r8a7779_add_ether_device(struct sh_eth_plat_data *pdata)
> -{
> - platform_device_register_resndata(&platform_bus, "r8a777x-ether", -1,
> - ether_resources,
> - ARRAY_SIZE(ether_resources),
> - pdata, sizeof(*pdata));
> -}
> -
> /* do nothing for !CONFIG_SMP or !CONFIG_HAVE_TWD */
> void __init __weak r8a7779_register_twd(void) { }
WBR, Sergei
prev parent reply other threads:[~2013-11-01 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 1:00 [PATCH 2/2] ARM: shmobile: r8a7779: cleanup registration of sh_eth Kuninori Morimoto
2013-11-01 12:24 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52739D7D.40409@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).