From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ARM: shmobile: r8a779[01]: Add SSI clocks in device tree
Date: Thu, 13 Feb 2014 14:48:04 +0000 [thread overview]
Message-ID: <5275812.0DfTgYCuTW@avalon> (raw)
Hi Mike,
On Wednesday 25 December 2013 21:34:33 Laurent Pinchart wrote:
> Hello,
>
> These two patches add the SSI clocks to the r8a7790 and r8a7791 device tree.
>
> Compared to v1, the SSIn clocks now reference their parent using index 0
> instead of index R8A779[01]_CLK_SSI (which is equal to 5). The clocks
> property is used to look up the clock parent name (possibly before the
> clock parent is even registered), not the clock parent itself. As clock
> parent names are always looked up directly by index, replace the clock
> provider index by the parent index in the clock-output-names list.
>
> Mike, is this the correct thing to do ? The different meanings of the clocks
> property depending on whether it's located in a clock provider node or a
> clock consumer node are not really intuitive. This should probably be
> documented in Documentation/devicetree/bindings/clock/clock-bindings.txt.
Ping ?
> Laurent Pinchart (2):
> ARM: shmobile: r8a7790: Add SSI clocks in device tree
> ARM: shmobile: r8a7791: Add SSI clocks in device tree
>
> arch/arm/boot/dts/r8a7790.dtsi | 18 ++++++++++++++++++
> arch/arm/boot/dts/r8a7791.dtsi | 18 ++++++++++++++++++
> include/dt-bindings/clock/r8a7790-clock.h | 13 +++++++++++++
> include/dt-bindings/clock/r8a7791-clock.h | 13 +++++++++++++
> 4 files changed, 62 insertions(+)
--
Regards,
Laurent Pinchart
next reply other threads:[~2014-02-13 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 14:48 Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-25 20:34 [PATCH v2 0/2] ARM: shmobile: r8a779[01]: Add SSI clocks in device tree Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5275812.0DfTgYCuTW@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox