From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] RM: shmobile: lager: phy fixup needs CONFIG_PHYLIB
Date: Tue, 05 Nov 2013 20:25:41 +0000 [thread overview]
Message-ID: <5279624F.1030903@cogentembedded.com> (raw)
In-Reply-To: <5272CC16.3020700@cogentembedded.com>
Hello.
On 11/01/2013 12:31 AM, Sergei Shtylyov wrote:
>> Do not build the phy fixup unless CONFIG_PHYLIB is enabled.
>> Other than not being useful it is also not possible to compile
> s/compile/link/.
>> the code under this condition as phy_register_fixup_for_id()
>> is not defined.
> Not only this function is absent...
>> This problem was introduced by 48c8b96f21817aad
>> ("ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup")
>> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> ---
>> arch/arm/mach-shmobile/board-lager.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> diff --git a/arch/arm/mach-shmobile/board-lager.c
>> b/arch/arm/mach-shmobile/board-lager.c
>> index 78a31b6..d1a8ddd 100644
>> --- a/arch/arm/mach-shmobile/board-lager.c
>> +++ b/arch/arm/mach-shmobile/board-lager.c
>> @@ -245,7 +245,9 @@ static void __init lager_init(void)
>> {
>> lager_add_standard_devices();
>>
>> - phy_register_fixup_for_id("r8a7790-ether-ff:01", lager_ksz8041_fixup);
>> + if (IS_ENABLED(CONFIG_PHYLIB))
>> + phy_register_fixup_for_id("r8a7790-ether-ff:01",
>> + lager_ksz8041_fixup);
> Perhaps you would consider enclosing the fixup function itself into #ifdef
> as it causes link errors as well? Doesn't seem necessary as gcc probably
> drops it anyway but for completeness' sake...
It's not necessary and it won't even work (causes compilation failure) as
my testing has shown, so sorry for wasting your time on this suggestion.
WBR, Sergei
prev parent reply other threads:[~2013-11-05 20:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 6:31 [PATCH] RM: shmobile: lager: phy fixup needs CONFIG_PHYLIB Simon Horman
2013-10-31 20:31 ` Sergei Shtylyov
2013-11-01 0:43 ` Simon Horman
2013-11-01 23:30 ` Sergei Shtylyov
2013-11-04 23:58 ` Simon Horman
2013-11-05 16:53 ` Sergei Shtylyov
2013-11-05 20:25 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5279624F.1030903@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).