linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valentine <valentine.barshak@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: phy: R-Car Gen2: Use usb_phy_add_dev
Date: Mon, 09 Dec 2013 19:33:09 +0000	[thread overview]
Message-ID: <52A61AF5.9090708@cogentembedded.com> (raw)
In-Reply-To: <1386592505-24585-1-git-send-email-valentine.barshak@cogentembedded.com>

On 12/09/2013 04:35 PM, Valentine Barshak wrote:
> Use add_phy_dev instead of usb_phy_add, so that devices can
> be bound to the phy. This is needed to set up USB phy for
> some internal PCI USB host controllers on R-Car Gen2.
>
> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
> ---
>   drivers/usb/phy/phy-rcar-gen2-usb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c
> index db3ab34..551e0a6 100644
> --- a/drivers/usb/phy/phy-rcar-gen2-usb.c
> +++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
> @@ -213,7 +213,7 @@ static int rcar_gen2_usb_phy_probe(struct platform_device *pdev)
>   	priv->phy.shutdown = rcar_gen2_usb_phy_shutdown;
>   	priv->phy.set_suspend = rcar_gen2_usb_phy_set_suspend;
>
> -	retval = usb_add_phy(&priv->phy, USB_PHY_TYPE_USB2);
> +	retval = usb_add_phy_dev(&priv->phy);
>   	if (retval < 0) {
>   		dev_err(dev, "Failed to add USB phy\n");
>   		return retval;
>

Please, disregard this one as it uses slightly incorrect function names in the commit log.
I'll update the log message and submit V2 in a bit.
Sorry for the noise.

Thanks,
Val.

      reply	other threads:[~2013-12-09 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09 12:35 [PATCH] usb: phy: R-Car Gen2: Use usb_phy_add_dev Valentine Barshak
2013-12-09 19:33 ` Valentine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A61AF5.9090708@cogentembedded.com \
    --to=valentine.barshak@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).