From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 09 Dec 2013 18:58:02 +0000 Subject: Re: [PATCH 2/2] ARM: shmobile: Koelsch: add Ether support Message-Id: <52A620C5.9030600@cogentembedded.com> List-Id: References: <201310310216.28673.sergei.shtylyov@cogentembedded.com> <201310310219.58963.sergei.shtylyov@cogentembedded.com> <5272A98B.3030705@cogentembedded.com> In-Reply-To: <5272A98B.3030705@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 10/31/2013 10:03 PM, I wrote: >>> Register Ether platform device and pin data on the Koelsch board. >>> Register platform fixup for Micrel KSZ8041 PHY, just like on the Lager board. >>> Signed-off-by: Sergei Shtylyov >> Thanks for your patch. Just like on the Lager board we also need to >> tie in the PHY IRQ pin. > Not only on the Lager board, BOCK-W also I think. >> Polling is not good enough when the hardware >> can do better. Can you please share your PHY IRQ plans with us? > It's on my agenda now -- will start after I do away with the CAN driver > and the current Koelsch Ether support. I have now implemented PHY IRQ support for BOCK-W, Lager, and Koelsch boards (had to extend the Micrel PHY driver to recognize undocumented KSZ8041RNLI PHY ID for that) but I must say that the PHY interrupt doesn't get generated on either of the board and I don't know why yet (I can't rule out the INTC driver issue); that's bad news. Good news is that even this doesn't prevent phylib from working properly as it still polls the PHY once a second. >> Best, >> / magnus WBR, Sergei