From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Wed, 11 Dec 2013 18:22:19 +0000 Subject: Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST Message-Id: <52A8AD5B.70601@cogentembedded.com> List-Id: References: <1385515117-23664-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1385515117-23664-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <52A8A891.40302@cogentembedded.com> <1488247.0AdahCZr3G@avalon> In-Reply-To: <1488247.0AdahCZr3G@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 11-12-2013 22:06, Laurent Pinchart wrote: >>> This helps increasing build testing coverage. >>> The driver doesn't compile on (at least) x86 due (possibly among others) >>> to missing readsw/writesw I/O accessors, restrict compilation to SUPERH >>> or ARM. >>> Whether the CTL_DMA_ENABLE register is part of the standard TMIO >>> controller or is Renesas-specific is unknown and impossible to test as >>> we have no current or planned TMIO DMA users other than SUPERH and >>> ARCH_SHMOBILE. Writing to the register is thus conditionally compiled >>> for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the >>> list would extend this to multiarch kernels, but would break the driver >>> for non-shmobile platforms if the register is Renesas-specific. We can >>> thus get rid of the conditional compilation completely without >>> introducing any further issue, and let future non-Renesas users deal >>> with the situation if it turns out to be a the problem. >>> Cc: Chris Ball >>> Cc: Guennadi Liakhovetski >>> Cc: Ian Molton >>> Cc: linux-mmc@vger.kernel.org >>> Signed-off-by: Laurent Pinchart >>> >>> Acked-by: Simon Horman [...] >>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >>> index 7fc5099..ca1315e 100644 >>> --- a/drivers/mmc/host/Kconfig >>> +++ b/drivers/mmc/host/Kconfig >>> @@ -479,7 +479,8 @@ config MMC_TMIO >>> >>> config MMC_SDHI >>> >>> tristate "SH-Mobile SDHI SD/SDIO controller support" >>> >>> - depends on SUPERH || ARCH_SHMOBILE >>> + depends on SUPERH || ARM >>> + depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST >> Hm, why 2 "depends" lines with SUPERH in both? > The first line means "this driver requires SUPERH || ARM to be compiled", Then COMPILE_TEST should be there, no? > while the second line means "devices supported by this driver are only found > on SUPERH || ARCH_SHMOBILE platforms". WBR, Sergei