Re: [PATCH] sh: Add EXPORT_SYMBOL(min_low_pfn) and EXPORT_SYMBOL(max_low_pfn) to sh_ksyms_32.c

[Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>]

Hi,

(2013/12/13 12:17), Kuninori Morimoto wrote:
>
> Hi
>
>
>>> EXPORT_SYMBOL() on arch/sh/kernel/sh_ksyms_32.c
>>> seems strange for me.
>>
>> Handling of these depends on CPUs.
>> And in SH32, it may be referred to from modules.
>> Therefore, I have feeling that it is not amusing that sh_ksyms_32.c defines these using EXPORT_SYMBOL.
>>
>> Would you explain the reason that you thought to be strange?
>
> I think EXPORT_SYMBOL() should be called
> from ${LINUX}/mm/[no]bootmem.c, not sh_ksyms_32.c

The usage of max_low_pfn and min_low_pfn depend on the architecture as I have described above.
You do not need to set as EXPORT_SYMBOL these all architectures.

Best regards,
   Nobuhiro