From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-sh@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH RFC 3/3] [RFC] ARM: shmobile: genmai: Enable r7s72100-gether
Date: Sun, 15 Dec 2013 19:31:39 +0000 [thread overview]
Message-ID: <52AE11A7.6090407@cogentembedded.com> (raw)
In-Reply-To: <1387095886-15163-4-git-send-email-horms+renesas@verge.net.au>
Hello.
On 12/15/2013 11:24 AM, Simon Horman wrote:
You forgot to sign off.
[...]
> diff --git a/arch/arm/mach-shmobile/board-genmai.c b/arch/arm/mach-shmobile/board-genmai.c
> index 3e92e3c..838325b 100644
> --- a/arch/arm/mach-shmobile/board-genmai.c
> +++ b/arch/arm/mach-shmobile/board-genmai.c
> @@ -20,15 +20,35 @@
>
> #include <linux/kernel.h>
> #include <linux/platform_device.h>
> +#include <linux/sh_eth.h>
> #include <mach/common.h>
> +#include <mach/irqs.h>
> #include <mach/r7s72100.h>
> #include <asm/mach-types.h>
> #include <asm/mach/arch.h>
>
> +/* GEther */
> +static const struct sh_eth_plat_data gether_pdata __initconst = {
> + .phy = 0x00, /* PD60610 */
> + .edmac_endian = EDMAC_LITTLE_ENDIAN,
> + .phy_interface = PHY_INTERFACE_MODE_MII,
Does MII work for Gigabit Ethernet?
WBR, Sergei
next prev parent reply other threads:[~2013-12-15 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 8:24 [PATCH RFC 0/3] Add ethernet support for r7s72100 Simon Horman
2013-12-15 8:24 ` [PATCH RFC net-next 1/3] [RFC] sh_eth: Add " Simon Horman
2013-12-24 20:25 ` Sergei Shtylyov
2013-12-15 8:24 ` [PATCH RFC 2/3] [RFC] ARM: shmobile: r7s72100: Add clock for r7s72100-gether Simon Horman
2013-12-15 19:19 ` Sergei Shtylyov
2013-12-16 1:31 ` Simon Horman
2013-12-15 8:24 ` [PATCH RFC 3/3] [RFC] ARM: shmobile: genmai: Enable r7s72100-gether Simon Horman
2013-12-15 19:31 ` Sergei Shtylyov [this message]
2013-12-16 1:30 ` Simon Horman
2013-12-24 20:44 ` Sergei Shtylyov
2013-12-24 20:45 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AE11A7.6090407@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms+renesas@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).