Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Valentine <valentine.barshak@cogentembedded.com>]

On 12/19/2013 02:09 PM, Magnus Damm wrote:
> Hi Valentine,
>
> Thanks for posting this patch series.
>
> On Wed, Dec 18, 2013 at 9:44 PM, Valentine Barshak
> <valentine.barshak@cogentembedded.com> wrote:
>> I've decided to bundle USB and SATA patches together, since I've done SATA on top of USB.
>> Most of the SATA/USBHS/PCI USB host support patches for Lager are available in the respective
>> susbsystem git trees (for 3.14) but are still missing from the Renesas tree.
>>
>> So, in order to test these, the following patches from other subsystem trees are needed:
>> USB:
>> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
>> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e
>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747
>
> So let me clarify about the above, this is for USB Host 2.0 support
> only? Or is USB Function also included? If both are included, can you
> please show me the dependencies for USB Function by itself?
>

Both, USBHS and USB host depend on the following commits:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e

USB Host also needs these:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747
https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1

>> SATA:
>> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>
> This patch looks like a small enough dependency for us to handle
> easily. I propose that we begin getting this one merged.

Just FYI, there's also another patch in libata tree that adds documentation for the SATA DT bindings:
https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&id€361fa02e59cbc4ddfd4ceae18441092797149f
It may need some updates in the future due to recent CCF DT work. Not sure if you want to merge it as well, it's just a .txt file.

>
>> The USB channel 0 (CN6) is configured as PCI USB host if USB_RENESAS_USBHS_UDC is disabled.
>> Otherwise it is configured as USBHS device.
>> Please note that the following switches have to be set correctly as well:
>> PCI USB Host: SW5 - pin1;    SW6 - pin1
>> USBHS device: SW5 - neutral; SW6 - pin3
>>
>> Valentine Barshak (5):
>>    arm: shmobile: r8a7790: Add PCI USB host clock support
>>    arm: shmobile: r8a7790: Add SATA clock
>>    arm: shmobile: lager: Add USBHS support
>>    arm: shmobile: lager: Add internal PCI support
>>    arm: shmobile: lager: Add SATA support
>
> May I ask you to break out the SATA bits and submit them as a separate
> series. I'd like to try them on both Lager and Koelsch, so if you
> happen to have patches for both boards then that would be great
> (platform device style for now is acceptable to me).

Sure,
I'll break out the SATA.
I'll try to produce some patches for Koelsch as well.
I'll let you know hot it goes later today.

>
> Timing wise we're a bit unfortunate with the holidays and all, but I
> will do my best to work with Simon to get your code merged.

Thanks!

> I will probably ask you to add support for DT via CCF and MULTIPLATFORM in
> the not too distant future, hope that's ok.

Yes, that was next on my to-do list. I'm just not sure about the latest CCF status.
Do I wait until it's merged, or should I use clocks/ccf/rcar-gen2-clocks branch from Laurent's tree?

>
> When we're done with SATA then i'd like to give USB Function a go too,
> please let me know those dependencies.
>
> Cheers,
>
> / magnus
>

Thanks,
Val.