[PATCH 0/2] arm: shmobile: Add SATA support for Lager board

[PATCH 0/2] arm: shmobile: Add SATA support for Lager board

[Valentine Barshak]

This adds SATA0/1 clocks to R8A7790 SoC and adds SATA1 to Lager board.
SATA0 is not available on Lager since MD23 selection is fixed to USB3.

It depends on the following commit available in the libata git tree:
https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3

Valentine Barshak (2):
  arm: shmobile: r8a7790: Add SATA clock
  arm: shmobile: lager: Add SATA support

 arch/arm/mach-shmobile/board-lager.c   | 17 +++++++++++++++++
 arch/arm/mach-shmobile/clock-r8a7790.c | 19 +++++++++++++++++++
 2 files changed, 36 insertions(+)

-- 
1.8.3.1

[PATCH 0/2] arm: shmobile: Add SATA support for Koelsch board

[Valentine Barshak]

This adds SATA0/1 clocks to R8A7791 SoC and adds SATA0 to Koelsch board.
SATA1 is not available on Koelsch since MD24 selection is fixed to PCIe.

It depends on the following commit available in the libata git tree:
https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3

Valentine Barshak (2):
  arm: shmobile: r8a7791: Add SATA clocks
  arm: shmobile: koelsch: Add SATA support

 arch/arm/mach-shmobile/board-koelsch.c | 17 +++++++++++++++++
 arch/arm/mach-shmobile/clock-r8a7791.c | 19 +++++++++++++++++++
 2 files changed, 36 insertions(+)

-- 
1.8.3.1

Re: [PATCH 0/2] arm: shmobile: Add SATA support for Lager board

[Magnus Damm]

On Fri, Dec 20, 2013 at 2:57 AM, Valentine Barshak
<valentine.barshak@cogentembedded.com> wrote:
> This adds SATA0/1 clocks to R8A7790 SoC and adds SATA1 to Lager board.
> SATA0 is not available on Lager since MD23 selection is fixed to USB3.
>
> It depends on the following commit available in the libata git tree:
> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>
> Valentine Barshak (2):
>   arm: shmobile: r8a7790: Add SATA clock
>   arm: shmobile: lager: Add SATA support
>
>  arch/arm/mach-shmobile/board-lager.c   | 17 +++++++++++++++++
>  arch/arm/mach-shmobile/clock-r8a7790.c | 19 +++++++++++++++++++
>  2 files changed, 36 insertions(+)

Hi Valentine and Simon,

Thanks for your patches. I have now successfully tested this Lager
SATA (pdev) series on my hardware. My SATA HDD can be used on Lager as
long as the drive is powered on before kernel boot.

Due to delay on my side (my apologies, moved house) there seems to
have been some bitrot, so I had to manually fix up the patches to make
them fit on "renesas-devel-v3.13-rc7-20140108". It seems to me that
you may need to use SH_CLK_MSTP32_STS() now, so I suspect that you
need to update the patch series to match latest devel tag. Feel free
to include this:

Acked-by: Magnus Damm <damm@opensource.se>

Also, the Lager defconfig probably wants to be updated to include SATA support.

Simon, can you please work with Valentine to merge this series?

Cheers,

/ magnus

Re: [PATCH 0/2] arm: shmobile: Add SATA support for Koelsch board

[Magnus Damm]

On Fri, Dec 20, 2013 at 2:59 AM, Valentine Barshak
<valentine.barshak@cogentembedded.com> wrote:
> This adds SATA0/1 clocks to R8A7791 SoC and adds SATA0 to Koelsch board.
> SATA1 is not available on Koelsch since MD24 selection is fixed to PCIe.
>
> It depends on the following commit available in the libata git tree:
> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>
> Valentine Barshak (2):
>   arm: shmobile: r8a7791: Add SATA clocks
>   arm: shmobile: koelsch: Add SATA support
>
>  arch/arm/mach-shmobile/board-koelsch.c | 17 +++++++++++++++++
>  arch/arm/mach-shmobile/clock-r8a7791.c | 19 +++++++++++++++++++
>  2 files changed, 36 insertions(+)

Hi Valentine and Simon,

I have now tested this Koelsch SATA series as well. It works well as
long as the HDD is powered on at boot. When applying the patches I
noticed that there were fewer collisions here due to no legacy clock
status bit polling patch for r8a7791.

Acked-by: Magnus Damm <damm@opensource.se>

Simon, can you please work with Valentine to merge this series?

Valentine, now when CCF support is included in recent devel tags, can
you please consider cooking up DTS patches for SATA for the
MULTIPLATFORM board support case for Lager and Koelsch?

Thanks,

/ magnus

Re: [PATCH 0/2] arm: shmobile: Add SATA support for Lager board

[Simon Horman]

On Wed, Jan 08, 2014 at 03:40:23PM +0900, Magnus Damm wrote:
> On Fri, Dec 20, 2013 at 2:57 AM, Valentine Barshak
> <valentine.barshak@cogentembedded.com> wrote:
> > This adds SATA0/1 clocks to R8A7790 SoC and adds SATA1 to Lager board.
> > SATA0 is not available on Lager since MD23 selection is fixed to USB3.
> >
> > It depends on the following commit available in the libata git tree:
> > https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
> >
> > Valentine Barshak (2):
> >   arm: shmobile: r8a7790: Add SATA clock
> >   arm: shmobile: lager: Add SATA support
> >
> >  arch/arm/mach-shmobile/board-lager.c   | 17 +++++++++++++++++
> >  arch/arm/mach-shmobile/clock-r8a7790.c | 19 +++++++++++++++++++
> >  2 files changed, 36 insertions(+)
> 
> Hi Valentine and Simon,
> 
> Thanks for your patches. I have now successfully tested this Lager
> SATA (pdev) series on my hardware. My SATA HDD can be used on Lager as
> long as the drive is powered on before kernel boot.
> 
> Due to delay on my side (my apologies, moved house) there seems to
> have been some bitrot, so I had to manually fix up the patches to make
> them fit on "renesas-devel-v3.13-rc7-20140108". It seems to me that
> you may need to use SH_CLK_MSTP32_STS() now, so I suspect that you
> need to update the patch series to match latest devel tag. Feel free
> to include this:
> 
> Acked-by: Magnus Damm <damm@opensource.se>
> 
> Also, the Lager defconfig probably wants to be updated to include SATA support.
> 
> Simon, can you please work with Valentine to merge this series?

Sure, will do.

Re: [PATCH 0/2] arm: shmobile: Add SATA support for Koelsch board

[Simon Horman]

On Wed, Jan 08, 2014 at 04:18:12PM +0900, Magnus Damm wrote:
> On Fri, Dec 20, 2013 at 2:59 AM, Valentine Barshak
> <valentine.barshak@cogentembedded.com> wrote:
> > This adds SATA0/1 clocks to R8A7791 SoC and adds SATA0 to Koelsch board.
> > SATA1 is not available on Koelsch since MD24 selection is fixed to PCIe.
> >
> > It depends on the following commit available in the libata git tree:
> > https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
> >
> > Valentine Barshak (2):
> >   arm: shmobile: r8a7791: Add SATA clocks
> >   arm: shmobile: koelsch: Add SATA support
> >
> >  arch/arm/mach-shmobile/board-koelsch.c | 17 +++++++++++++++++
> >  arch/arm/mach-shmobile/clock-r8a7791.c | 19 +++++++++++++++++++
> >  2 files changed, 36 insertions(+)
> 
> Hi Valentine and Simon,
> 
> I have now tested this Koelsch SATA series as well. It works well as
> long as the HDD is powered on at boot. When applying the patches I
> noticed that there were fewer collisions here due to no legacy clock
> status bit polling patch for r8a7791.
> 
> Acked-by: Magnus Damm <damm@opensource.se>
> 
> Simon, can you please work with Valentine to merge this series?

Sure.

Valentine, can you rebase and repost the series?

> 
> Valentine, now when CCF support is included in recent devel tags, can
> you please consider cooking up DTS patches for SATA for the
> MULTIPLATFORM board support case for Lager and Koelsch?
> 
> Thanks,
> 
> / magnus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 0/2] arm: shmobile: Add SATA support for Lager board

[Valentine]

On 01/08/2014 10:40 AM, Magnus Damm wrote:
> On Fri, Dec 20, 2013 at 2:57 AM, Valentine Barshak
> <valentine.barshak@cogentembedded.com> wrote:
>> This adds SATA0/1 clocks to R8A7790 SoC and adds SATA1 to Lager board.
>> SATA0 is not available on Lager since MD23 selection is fixed to USB3.
>>
>> It depends on the following commit available in the libata git tree:
>> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>>
>> Valentine Barshak (2):
>>    arm: shmobile: r8a7790: Add SATA clock
>>    arm: shmobile: lager: Add SATA support
>>
>>   arch/arm/mach-shmobile/board-lager.c   | 17 +++++++++++++++++
>>   arch/arm/mach-shmobile/clock-r8a7790.c | 19 +++++++++++++++++++
>>   2 files changed, 36 insertions(+)
>
> Hi Valentine and Simon,

Magnus, Simon,

>
> Thanks for your patches. I have now successfully tested this Lager
> SATA (pdev) series on my hardware. My SATA HDD can be used on Lager as
> long as the drive is powered on before kernel boot.
>
> Due to delay on my side (my apologies, moved house) there seems to
> have been some bitrot, so I had to manually fix up the patches to make
> them fit on "renesas-devel-v3.13-rc7-20140108". It seems to me that
> you may need to use SH_CLK_MSTP32_STS() now, so I suspect that you
> need to update the patch series to match latest devel tag. Feel free
> to include this:
>
> Acked-by: Magnus Damm <damm@opensource.se>

Thanks.

It's not just the SH_CLK_MSTP32_STS thing. The SATA clock parent has to be changed to zs_clk as well.
I've posted the patch for the clocks in a separate series here:
http://marc.info/?l=linux-sh&m\x138919869800851&w=2

I have the updated SATA support ready, but it still depends on
https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
Do you plan to merge it or do we have to wait for 3.15?

I have done some experiments with CCF as well.
I could post the patches but there are still some dependencies on the other
patches that are still pending.
Do you want me to send them anyway or should we wait until the following patches are applied:
http://marc.info/?l=linux-sh&m\x138823255807611&w=2
http://marc.info/?l=linux-sh&m\x138908294932253&w=2
?

>
> Also, the Lager defconfig probably wants to be updated to include SATA support.
>
> Simon, can you please work with Valentine to merge this series?
>
> Cheers,
>
> / magnus
>

Thanks,
Val.

Re: [PATCH 0/2] arm: shmobile: Add SATA support for Lager board

[Magnus Damm]

On Thu, Jan 9, 2014 at 2:00 AM, Valentine
<valentine.barshak@cogentembedded.com> wrote:
> On 01/08/2014 10:40 AM, Magnus Damm wrote:
>>
>> On Fri, Dec 20, 2013 at 2:57 AM, Valentine Barshak
>> <valentine.barshak@cogentembedded.com> wrote:
>>>
>>> This adds SATA0/1 clocks to R8A7790 SoC and adds SATA1 to Lager board.
>>> SATA0 is not available on Lager since MD23 selection is fixed to USB3.
>>>
>>> It depends on the following commit available in the libata git tree:
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>>>
>>> Valentine Barshak (2):
>>>    arm: shmobile: r8a7790: Add SATA clock
>>>    arm: shmobile: lager: Add SATA support
>>>
>>>   arch/arm/mach-shmobile/board-lager.c   | 17 +++++++++++++++++
>>>   arch/arm/mach-shmobile/clock-r8a7790.c | 19 +++++++++++++++++++
>>>   2 files changed, 36 insertions(+)

Hi Valentine,

>> Due to delay on my side (my apologies, moved house) there seems to
>> have been some bitrot, so I had to manually fix up the patches to make
>> them fit on "renesas-devel-v3.13-rc7-20140108". It seems to me that
>> you may need to use SH_CLK_MSTP32_STS() now, so I suspect that you
>> need to update the patch series to match latest devel tag. Feel free
>> to include this:
>>
>> Acked-by: Magnus Damm <damm@opensource.se>
>
>
> Thanks.
>
> It's not just the SH_CLK_MSTP32_STS thing. The SATA clock parent has to be
> changed to zs_clk as well.
> I've posted the patch for the clocks in a separate series here:
> http://marc.info/?l=linux-sh&m\x138919869800851&w=2
>
> I have the updated SATA support ready, but it still depends on
> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
> Do you plan to merge it or do we have to wait for 3.15?

Thanks. I believe Simon will help you getting the necessary bits
merged. Do you need to change the parent clock for r8a7791 as well
perhaps? If so, please post patches so we can merge Koelsch support as
well.

> I have done some experiments with CCF as well.
> I could post the patches but there are still some dependencies on the other
> patches that are still pending.
> Do you want me to send them anyway or should we wait until the following
> patches are applied:
> http://marc.info/?l=linux-sh&m\x138823255807611&w=2

Thanks for submitting fixes. I believe these patches have been acked
by Laurent and picked up by Mike Turquette for upstream merge. So they
seem under control.

> http://marc.info/?l=linux-sh&m\x138908294932253&w=2

Regarding this one, can you please verify that it includes the correct
parent clock and then reply with a tested-by for the SATA patches?

Once we got the SATA platform device bits merged then I'd like to
switch focus to SATA DTS, hope that is ok with you.

Thanks for your help!

Cheers,

/ magnus

Re: [PATCH 0/2] arm: shmobile: Add SATA support for Lager board

[Simon Horman]

On Wed, Jan 08, 2014 at 09:00:02PM +0400, Valentine wrote:
> On 01/08/2014 10:40 AM, Magnus Damm wrote:
> >On Fri, Dec 20, 2013 at 2:57 AM, Valentine Barshak
> ><valentine.barshak@cogentembedded.com> wrote:
> >>This adds SATA0/1 clocks to R8A7790 SoC and adds SATA1 to Lager board.
> >>SATA0 is not available on Lager since MD23 selection is fixed to USB3.
> >>
> >>It depends on the following commit available in the libata git tree:
> >>https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
> >>
> >>Valentine Barshak (2):
> >>   arm: shmobile: r8a7790: Add SATA clock
> >>   arm: shmobile: lager: Add SATA support
> >>
> >>  arch/arm/mach-shmobile/board-lager.c   | 17 +++++++++++++++++
> >>  arch/arm/mach-shmobile/clock-r8a7790.c | 19 +++++++++++++++++++
> >>  2 files changed, 36 insertions(+)
> >
> >Hi Valentine and Simon,
> 
> Magnus, Simon,
> 
> >
> >Thanks for your patches. I have now successfully tested this Lager
> >SATA (pdev) series on my hardware. My SATA HDD can be used on Lager as
> >long as the drive is powered on before kernel boot.
> >
> >Due to delay on my side (my apologies, moved house) there seems to
> >have been some bitrot, so I had to manually fix up the patches to make
> >them fit on "renesas-devel-v3.13-rc7-20140108". It seems to me that
> >you may need to use SH_CLK_MSTP32_STS() now, so I suspect that you
> >need to update the patch series to match latest devel tag. Feel free
> >to include this:
> >
> >Acked-by: Magnus Damm <damm@opensource.se>
> 
> Thanks.
> 
> It's not just the SH_CLK_MSTP32_STS thing. The SATA clock parent has to be changed to zs_clk as well.
> I've posted the patch for the clocks in a separate series here:
> http://marc.info/?l=linux-sh&m\x138919869800851&w=2

Thanks, I have queued up the SATA patch from that series.

> I have the updated SATA support ready, but it still depends on
> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
> Do you plan to merge it or do we have to wait for 3.15?

My understanding is that the patch has been merged by Tejun Heo
and will be present in v3.14.

As far as I can see this series does not have any run or build
time dependencies on the driver: the board will boot fine, it
just wont have access to SATA. So I have merged this series
independently of Tejun's tree.

Unfortunately it is now too late (by several weeks) for me to
queue up non-fix patches for v3.14. So I have queued it up for v3.15.

> I have done some experiments with CCF as well.
> I could post the patches but there are still some dependencies on the other
> patches that are still pending.
> Do you want me to send them anyway or should we wait until the following patches are applied:
> http://marc.info/?l=linux-sh&m\x138823255807611&w=2
> http://marc.info/?l=linux-sh&m\x138908294932253&w=2
> ?
> 
> >
> >Also, the Lager defconfig probably wants to be updated to include SATA support.

Please send a patch to update the defconfig for Lager.
And likewise for Koelsch.

Re: [PATCH 0/2] arm: shmobile: Add SATA support for Koelsch board

[Simon Horman]

On Wed, Jan 08, 2014 at 04:27:09PM +0900, Simon Horman wrote:
> On Wed, Jan 08, 2014 at 04:18:12PM +0900, Magnus Damm wrote:
> > On Fri, Dec 20, 2013 at 2:59 AM, Valentine Barshak
> > <valentine.barshak@cogentembedded.com> wrote:
> > > This adds SATA0/1 clocks to R8A7791 SoC and adds SATA0 to Koelsch board.
> > > SATA1 is not available on Koelsch since MD24 selection is fixed to PCIe.
> > >
> > > It depends on the following commit available in the libata git tree:
> > > https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
> > >
> > > Valentine Barshak (2):
> > >   arm: shmobile: r8a7791: Add SATA clocks
> > >   arm: shmobile: koelsch: Add SATA support
> > >
> > >  arch/arm/mach-shmobile/board-koelsch.c | 17 +++++++++++++++++
> > >  arch/arm/mach-shmobile/clock-r8a7791.c | 19 +++++++++++++++++++
> > >  2 files changed, 36 insertions(+)
> > 
> > Hi Valentine and Simon,
> > 
> > I have now tested this Koelsch SATA series as well. It works well as
> > long as the HDD is powered on at boot. When applying the patches I
> > noticed that there were fewer collisions here due to no legacy clock
> > status bit polling patch for r8a7791.
> > 
> > Acked-by: Magnus Damm <damm@opensource.se>
> > 
> > Simon, can you please work with Valentine to merge this series?
> 
> Sure.
> 
> Valentine, can you rebase and repost the series?

And include an update to the Koelsch defconfig