From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: shmobile: Fix MSTP clock index
Date: Thu, 09 Jan 2014 17:23:25 +0000 [thread overview]
Message-ID: <52CEDB0D.3080608@codethink.co.uk> (raw)
In-Reply-To: <1388167599-23525-2-git-send-email-valentine.barshak@cogentembedded.com>
On 09/01/14 17:21, Ben Dooks wrote:
> On 27/12/13 18:06, Valentine Barshak wrote:
>> Use clkidx when registering MSTP clocks instead of loop counter
>> since the value is then used to access the specific clock index bit
>> in the mstp register.
>>
>> The issue was introduced by the following commit:
>> f94859c215b6d977 "clk: shmobile: Add MSTP clock support"
>>
>> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Ben Dooks <ben.dooks@codethink.co.uk>
>
> We just caught this one, it really needs fixing in Simon's tree
> as it stops stuff working!
sorry, meant to say:
Tested-by: Ben Dooks <ben.dooks@codethink.co.uk>
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2014-01-09 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 18:06 [PATCH 1/2] clk: shmobile: Fix MSTP clock index Valentine Barshak
2014-01-09 17:21 ` Ben Dooks
2014-01-09 17:23 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CEDB0D.3080608@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).