From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@lists.codethink.co.uk,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Linus SH list <linux-sh@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI
Date: Mon, 13 Jan 2014 09:35:41 +0000 [thread overview]
Message-ID: <52D3B36D.8040902@codethink.co.uk> (raw)
In-Reply-To: <CAMuHMdU+SfjNJC_b_7ovT9Uf5p5MwB0iULjorzthcLJxYJ-00g@mail.gmail.com>
On 13/01/14 09:28, Geert Uytterhoeven wrote:
> On Fri, Jan 10, 2014 at 4:18 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> --- a/drivers/sh/Makefile
>> +++ b/drivers/sh/Makefile
>> @@ -3,7 +3,10 @@
>> #
>> obj-y := intc/
>>
>> +ifeq ($(CONFIG_COMMON_CLK),n)
>> obj-$(CONFIG_HAVE_CLK) += clk/
>> +endif
>> +
>
> This part breaks my Koelsch legacy (non-reference) build:
>
> arch/arm/kernel/built-in.o: In function `twd_local_timer_common_register':
> io.c:(.init.text+0x1804): undefined reference to `clk_enable'
> io.c:(.init.text+0x1828): undefined reference to `clk_get_rate'
...
>
> Both of my Koelsch legacy and reference configs have CONFIG_HAVE_CLK=y,
> but only the reference once has CONFIG_COMMON_CLK=y.
Hmm, thought undefined symbols got set to 'n'.
I can either fix this by
ifneq ($(CONFIG_COMMON_CLK),y)
endif
or adding an extra Kconfig for SH specific legacy clock code.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-01-13 9:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 15:18 [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI Ben Dooks
2014-01-11 13:06 ` Ben Dooks
2014-01-12 21:54 ` Laurent Pinchart
2014-01-12 22:01 ` Laurent Pinchart
2014-01-13 6:45 ` Ben Dooks
2014-01-13 22:37 ` Laurent Pinchart
2014-01-17 0:49 ` Mark Brown
2014-01-13 0:30 ` Simon Horman
2014-01-13 6:23 ` Ben Dooks
2014-01-13 9:28 ` Geert Uytterhoeven
2014-01-13 9:35 ` Ben Dooks [this message]
2014-01-13 9:47 ` Geert Uytterhoeven
2014-01-14 13:56 ` Ben Dooks
2014-01-14 23:55 ` Simon Horman
2014-01-15 19:46 ` Laurent Pinchart
2014-01-16 10:38 ` Ben Dooks
2014-01-16 17:25 ` Ben Dooks
2014-01-19 21:44 ` Laurent Pinchart
2014-01-20 11:47 ` Mark Brown
2014-01-20 12:01 ` Ben Dooks
2014-01-20 12:54 ` Mark Brown
2014-01-20 13:19 ` Ben Dooks
2014-01-20 15:48 ` Laurent Pinchart
2014-01-20 15:56 ` Mark Brown
2014-01-20 22:52 ` Laurent Pinchart
2014-03-11 19:15 ` Geert Uytterhoeven
2014-03-12 14:18 ` Laurent Pinchart
2014-03-12 15:28 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D3B36D.8040902@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).